Subject: Re: [PATCH iproute2 1/1] actions: Add support for user cookies

From: Jiri Pirko <[email-masked]>
Date: Thu, 23 Nov 2017 17:36:12 +0100

Sat, Apr 22, 2017 at 02:36:23PM CEST, [email-masked] wrote:

[...]

>@@ -274,8 +302,17 @@ tc_print_one_action(FILE *f, struct rtattr *arg)
> 		return err;
> 
> 	if (show_stats && tb[TCA_ACT_STATS]) {
>+
> 		fprintf(f, "\tAction statistics:\n");
> 		print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL);
>+		if (tb[TCA_ACT_COOKIE]) {
>+			int strsz = RTA_PAYLOAD(tb[TCA_ACT_COOKIE]);
>+			char b1[strsz+1];
>+
>+			fprintf(f, "\n\tcookie len %d %s ", strsz,
>+				hexstring_n2a(RTA_DATA(tb[TCA_ACT_COOKIE]),
>+					      strsz, b1, sizeof(b1)));
>+		}

Jamal, is there any particular reason that you print cookie only in case
you show stats? What is the relation between cookie and stats?

> 		fprintf(f, "\n");
> 	}
>-- 
>1.9.1