From: Andrew Lunn <andrew@lunn•ch>
To: Antoine Tenart <antoine.tenart@free-electrons•com>
Cc: rmk@armlinux•org.uk, f.fainelli@gmail•com, davem@davemloft•net,
gregory.clement@free-electrons•com,
thomas.petazzoni@free-electrons•com,
miquel.raynal@free-electrons•com, nadavh@marvell•com,
mw@semihalf•com, stefanc@marvell•com, ymarkman@marvell•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net] net: phy: marvell10g: fix the PHY id mask
Date: Tue, 28 Nov 2017 14:43:58 +0100 [thread overview]
Message-ID: <20171128134358.GC20797@lunn.ch> (raw)
In-Reply-To: <20171128132630.26619-1-antoine.tenart@free-electrons.com>
On Tue, Nov 28, 2017 at 02:26:30PM +0100, Antoine Tenart wrote:
> The Marvell 10G PHY driver supports different hardware revisions, which
> have their bits 3..0 differing. To get the correct revision number these
> bits should be ignored. This patch fixes this by using the already
> defined MARVELL_PHY_ID_MASK (0xfffffff0) instead of the custom
> 0xffffffff mask.
>
> Fixes: 20b2af32ff3f ("net: phy: add Marvell Alaska X 88X3310 10Gigabit PHY support")
> Suggested-by: Yan Markman <ymarkman@marvell•com>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2017-11-28 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:26 [PATCH net] net: phy: marvell10g: fix the PHY id mask Antoine Tenart
2017-11-28 13:43 ` Andrew Lunn [this message]
2017-11-28 15:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128134358.GC20797@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=antoine.tenart@free-electrons$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=miquel.raynal@free-electrons$(echo .)com \
--cc=mw@semihalf$(echo .)com \
--cc=nadavh@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmk@armlinux$(echo .)org.uk \
--cc=stefanc@marvell$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
--cc=ymarkman@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox