Subject: Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode

From: Andrew Lunn <[email-masked]>
Date: Fri, 1 Dec 2017 20:12:50 +0100

> So do we need to introduce a new interface type
> PHY_INTERFACE_MODE_2500SGMII or is there a way to deal with 2.5G
> SGMII ?

And just adding to what Florian said, you don't just add a new define
like this, you also need to add a user of it. Posting your MAC and PHY
driver making use of this symbol will make it a lot clearer why it is
needed and how it should be used.

       Andrew