Subject: Re: [PATCH v2 net-next] netlink: optimize err assignment

From: Stephen Hemminger <[email-masked]>
Date: Tue, 5 Dec 2017 15:03:10 -0800

On Sun, 03 Dec 2017 07:20:09 -0800
Eric Dumazet <[email-masked]> wrote:

> On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote:
> > From: yuan linyu <[email-masked]>
> > 
> > Signed-off-by: yuan linyu <[email-masked]>
> > ---
> > v2: fix kbuild test warning
> > ---
> >  net/netlink/af_netlink.c | 52 ++++++++++++++++++++----------------
> > ------------
> >  1 file changed, 22 insertions(+), 30 deletions(-)
> >   
> 
> I see no reason why we should accept this code churn.
> 
> This kind of change makes future fix backports harder.
> 

I more worried about the possibility of latent bugs.
Humans aren't perfect at following all code paths