From: Andrew Lunn <andrew@lunn•ch>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
Cc: "David S. Miller" <davem@davemloft•net>,
"Sergei Shtylyov" <sergei.shtylyov@cogentembedded•com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech•se>,
"Geert Uytterhoeven" <geert+renesas@glider•be>,
"Simon Horman" <horms+renesas@verge•net.au>,
netdev@vger•kernel.org, linux-renesas-soc@vger•kernel.org
Subject: Re: [PATCH v2] net: sh_eth: do not advertise Gigabit capabilities when not available
Date: Tue, 5 Dec 2017 18:55:15 +0100 [thread overview]
Message-ID: <20171205175515.GR12805@lunn.ch> (raw)
In-Reply-To: <20171205092952.3455-1-thomas.petazzoni@free-electrons.com>
On Tue, Dec 05, 2017 at 10:29:52AM +0100, Thomas Petazzoni wrote:
> Not all variants of the sh_eth hardware have Gigabit
> support. Unfortunately, the current driver doesn't tell the PHY about
> the limited MAC capabilities. Due to this, if you have a Gigabit
> capable PHY, the PHY will advertise its Gigabit capability and
> establish a link at 1Gbit/s, even though the MAC doesn't support it.
>
> In order to avoid this, we use the recently introduced
> phy_set_max_speed() to tell the PHY to not advertise speed higher than
> 100 MBit/s.
>
> Tested on a SH7786 platform, with a Gigabit PHY.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2017-12-05 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 9:29 [PATCH v2] net: sh_eth: do not advertise Gigabit capabilities when not available Thomas Petazzoni
2017-12-05 17:55 ` Andrew Lunn [this message]
2017-12-05 19:02 ` Sergei Shtylyov
2017-12-08 15:36 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205175515.GR12805@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=geert+renesas@glider$(echo .)be \
--cc=horms+renesas@verge$(echo .)net.au \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niklas.soderlund+renesas@ragnatech$(echo .)se \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox