Subject: Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics names

From: Andrew Lunn <[email-masked]>
Date: Mon, 11 Dec 2017 16:45:06 +0100

On Mon, Dec 11, 2017 at 03:16:25PM +0300, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <[email-masked]>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
> index 70efb74..f2d8063 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
> @@ -66,14 +66,14 @@ static const char aq_ethtool_stat_names[][ETH_GSTRING_LEN] = {
>  	"OutUCast",
>  	"OutMCast",
>  	"OutBCast",
> -	"InUCastOctects",
> -	"OutUCastOctects",
> -	"InMCastOctects",
> -	"OutMCastOctects",
> -	"InBCastOctects",
> -	"OutBCastOctects",
> -	"InOctects",
> -	"OutOctects",
> +	"InUCastOctets",
> +	"OutUCastOctets",
> +	"InMCastOctets",
> +	"OutMCastOctets",
> +	"InBCastOctets",
> +	"OutBCastOctets",
> +	"InOctets",
> +	"OutOctets",
>  	"InPacketsDma",
>  	"OutPacketsDma",
>  	"InOctetsDma",

Hi Igor

I know it is not nice, but maybe we need to consider this is part of
the kernel ABI? You could be breaking applications by making this
change.

What do others think?

	Andrew