public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, cphealy@gmail•com
Subject: Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs
Date: Fri, 15 Dec 2017 10:10:44 +0100	[thread overview]
Message-ID: <20171215091044.GE929@lunn.ch> (raw)
In-Reply-To: <1513302496-22888-1-git-send-email-f.fainelli@gmail.com>

On Thu, Dec 14, 2017 at 05:48:16PM -0800, Florian Fainelli wrote:
> Add an entry for the builtin PHYs present in the Broadcom BCM5395 switch. This
> allows us to retrieve the PHY statistics among other things.

>  static struct phy_driver broadcom_drivers[] = {
>  {
>  	.phy_id		= PHY_ID_BCM5411,
> @@ -679,6 +710,16 @@ static struct phy_driver broadcom_drivers[] = {
>  	.config_init	= brcm_fet_config_init,
>  	.ack_interrupt	= brcm_fet_ack_interrupt,
>  	.config_intr	= brcm_fet_config_intr,
> +}, {
> +	.phy_id		= PHY_ID_BCM5395,
> +	.phy_id_mask	= 0xfffffff0,
> +	.name		= "Broadcom BCM5395",
> +	.flags		= PHY_IS_INTERNAL,
> +	.features	= PHY_GBIT_FEATURES,
> +	.get_sset_count	= bcm_phy_get_sset_count,
> +	.get_strings	= bcm_phy_get_strings,
> +	.get_stats	= bcm53xx_phy_get_stats,
> +	.probe		= bcm53xx_phy_probe,
>  } };

Hi Florian

Is this the only PHY supported by this driver which has statistics?

   Andrew

  parent reply	other threads:[~2017-12-15  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  1:48 [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs Florian Fainelli
2017-12-15  2:00 ` Chris Healy
2017-12-15  9:10 ` Andrew Lunn [this message]
2017-12-15 20:08   ` Florian Fainelli
2017-12-15 20:41 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215091044.GE929@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=cphealy@gmail$(echo .)com \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox