Subject: Re: [Intel-wired-lan] [bpf-next V1-RFC PATCH 03/14] i40e: setup xdp_rxq_info

From: Jesper Dangaard Brouer <[email-masked]>
Date: Mon, 18 Dec 2017 14:05:56 +0100

On Mon, 18 Dec 2017 11:52:08 +0100
Björn Töpel <[email-masked]> wrote:

> > +       /* Flow director side channel does not invoke XDP/bpf */
> > +       if (rx_ring->vsi->type == I40E_VSI_FDIR)
> > +               xdp_rxq_info_type(&rx_ring->xdp_rxq, RXQ_TYPE_SINK);  
> 
> For me, it doesn't make sense to expose the FD Rx ring outside the
> scope of i40e driver. Check against VSI_MAIN in setup/cleanup so the
> FD ring is not exposed outside the driver. Maybe you can get rid of
> the RXQ_TYPE_SINK as well then.

Okay, took this advice and changed patch to instead check against
I40E_VSI_MAIN.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer