Subject: Re: [PATCH net v2] openvswitch: Fix pop_vlan action for double tagged frames

From: Jiri Benc <[email-masked]>
Date: Wed, 20 Dec 2017 18:41:17 +0100

On Wed, 20 Dec 2017 10:39:32 -0500, Eric Garver wrote:
> +	if (is_flow_key_valid(key) && key->eth.vlan.tci && key->eth.cvlan.tci)

Maybe (key->eth.vlan.tci & htons(VLAN_TAG_PRESENT)) for consistency
with the rest of the code? But it's just nitpicking.

The real problem here is when a double tagged packet leaves the ovs
bridge, it won't have the skb->protocol that the kernel expects: it
will be ethertype of the payload, while my understanding is it should
be the inner tpid, right?

This patch fixes that nicely for the pop vlan case. But what about
other cases? It seems to me that we need to add the logic to
key_extract.

Thanks!

 Jiri