From: Hangbin Liu <liuhangbin@gmail•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, jchapman@katalix•com
Subject: Re: [PATCH net] l2tp: fix missing print session offset info
Date: Fri, 22 Dec 2017 11:29:03 +0800 [thread overview]
Message-ID: <20171222032903.GD13972@leo.usersys.redhat.com> (raw)
In-Reply-To: <20171221.150836.1128769335522894244.davem@davemloft.net>
On Thu, Dec 21, 2017 at 03:08:36PM -0500, David Miller wrote:
> From: Hangbin Liu <liuhangbin@gmail•com>
> Date: Thu, 21 Dec 2017 14:45:30 +0800
>
> > + (session->offset &&
> > + nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||
>
> It really discourages people from reviewing your changes when they
> don't even compile.
Sh*t, I did compile and test my patch on the compiler. But forgot to the fix the
code on my laptop...Really sorry for this, I need to double check it before
send.
next prev parent reply other threads:[~2017-12-22 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 6:45 [PATCH net] l2tp: fix missing print session offset info Hangbin Liu
2017-12-21 20:08 ` David Miller
2017-12-22 3:29 ` Hangbin Liu [this message]
2017-12-22 3:32 ` [PATCHv2 " Hangbin Liu
2017-12-22 11:24 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222032903.GD13972@leo.usersys.redhat.com \
--to=liuhangbin@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jchapman@katalix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox