Subject: Re: [PATCH RFC 12/18] r8168: switch to phy_mii_ioctl

From: Andrew Lunn <[email-masked]>
Date: Fri, 22 Dec 2017 11:00:42 +0100

>  static int rtl8168_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>  {
> -	struct rtl8168_private *tp = netdev_priv(dev);
> -	struct mii_ioctl_data *data = if_mii(ifr);
> +	if (!netif_running(dev))
> +		return -ENODEV;

It is sometimes useful to be able to prod and poke the PHY when the
MAC is not running. Is this limit because of power saving?

Otherwise, this patch looks good.

Thanks
	Andrew