From: Greg KH <gregkh@linuxfoundation•org>
To: Yisheng Xie <xieyisheng1@huawei•com>
Cc: linux-mips@linux-mips•org, ulf.hansson@linaro•org,
jakub.kicinski@netronome•com, lgirdwood@gmail•com,
airlied@linux•ie, linux-pci@vger•kernel.org,
alsa-devel@alsa-project•org, dri-devel@lists•freedesktop.org,
platform-driver-x86@vger•kernel.org, linux-ide@vger•kernel.org,
linux-mtd@lists•infradead.org, daniel.vetter@intel•com,
tglx@linutronix•de, linux-watchdog@vger•kernel.org,
linux-rtc@vger•kernel.org, boris.brezillon@free-electrons•com,
andriy.shevchenko@linux•intel.com, vinod.koul@intel•com,
richard@nod•at, alexandre.belloni@free-electrons•com,
marek.vasut@gmail•com, industrypack-devel@lists•sourceforge.net,
jslaby@suse•com, dvhart@infradead•org, linux@roeck-us•net,
linux-media@vger•kernel.org, devel@driverdev•osuosl.org,
jason@lakedaemon•net, arnd@arndb•de, b.zolnierkie@samsung•com,
marc.zyngier@arm•com, linux-mmc@vger•kernel.org,
linux-can@vger•kernel.org, linux-gp
Subject: Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache
Date: Sat, 23 Dec 2017 14:45:32 +0100 [thread overview]
Message-ID: <20171223134532.GA10103@kroah.com> (raw)
In-Reply-To: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com>
On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote:
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset,
> EXPORT_SYMBOL(devm_ioremap);
>
> /**
> - * devm_ioremap_nocache - Managed ioremap_nocache()
> - * @dev: Generic device to remap IO address for
> - * @offset: Resource address to map
> - * @size: Size of map
> - *
> - * Managed ioremap_nocache(). Map is automatically unmapped on driver
> - * detach.
> - */
> -void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset,
> - resource_size_t size)
> -{
> - void __iomem **ptr, *addr;
> -
> - ptr = devres_alloc(devm_ioremap_release, sizeof(*ptr), GFP_KERNEL);
> - if (!ptr)
> - return NULL;
> -
> - addr = ioremap_nocache(offset, size);
Wait, devm_ioremap() calls ioremap(), not ioremap_nocache(), are you
_SURE_ that these are all identical? For all arches? If so, then
ioremap_nocache() can also be removed, right?
In my quick glance, I don't think you can do this series at all :(
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists•freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-12-23 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 11:02 [PATCH v3 27/27] devres: kill devm_ioremap_nocache Yisheng Xie
2017-12-23 13:45 ` Greg KH [this message]
2017-12-25 1:43 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223134532.GA10103@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=alexandre.belloni@free-electrons$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=arnd@arndb$(echo .)de \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=boris.brezillon@free-electrons$(echo .)com \
--cc=daniel.vetter@intel$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dvhart@infradead$(echo .)org \
--cc=industrypack-devel@lists$(echo .)sourceforge.net \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=jslaby@suse$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=marc.zyngier@arm$(echo .)com \
--cc=marek.vasut@gmail$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=richard@nod$(echo .)at \
--cc=tglx@linutronix$(echo .)de \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vinod.koul@intel$(echo .)com \
--cc=xieyisheng1@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox