From: Sowmini Varadhan <sowmini.varadhan@oracle•com>
To: Santosh Shilimkar <santosh.shilimkar@oracle•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH] rds: fix use-after-free read in rds_find_bound
Date: Sat, 30 Dec 2017 15:26:31 -0500 [thread overview]
Message-ID: <20171230202631.GB27855@oracle.com> (raw)
In-Reply-To: <1514662599-14491-1-git-send-email-santosh.shilimkar@oracle.com>
On (12/30/17 11:36), Santosh Shilimkar wrote:
>
> socket buffer can get freed as part of sock_close
> callback so before adding reference check underneath
> socket validity.
I'm not sure I understand this fix-
struct rds_sock is:
struct rds_sock {
struct sock rs_sk;
:
}
How can rs be non-null but rds_rs_to_sk() is null? (Note that
rds_rs_to_sk just returns &rs->rs_sk) so the changed line is
identical to the original line.
> - if (rs && !sock_flag(rds_rs_to_sk(rs), SOCK_DEAD))
> + if (rs && rds_rs_to_sk(rs) && !sock_flag(rds_rs_to_sk(rs), SOCK_DEAD))
I think the real issue is refcount bug somewhere,
Was the syzbot test run with http://patchwork.ozlabs.org/patch/852492/
this sounds like that type of bug.
--Sowmini
next prev parent reply other threads:[~2017-12-30 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 19:36 [PATCH] rds: fix use-after-free read in rds_find_bound Santosh Shilimkar
2017-12-30 20:26 ` Sowmini Varadhan [this message]
2017-12-30 21:37 ` santosh.shilimkar
2017-12-30 22:32 ` Sowmini Varadhan
2017-12-31 5:09 ` santosh.shilimkar
2017-12-31 12:33 ` Sowmini Varadhan
2017-12-31 22:30 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171230202631.GB27855@oracle.com \
--to=sowmini.varadhan@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=santosh.shilimkar@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox