From: Andrew Lunn <andrew@lunn•ch>
To: Marcin Wojtas <mw@semihalf•com>
Cc: "Graeme Gregory" <graeme.gregory@linaro•org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro•org>,
"linux-acpi@vger•kernel.org" <linux-acpi@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"<netdev@vger•kernel.org>" <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
"Russell King - ARM Linux" <linux@arm•linux.org.uk>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Antoine Ténart" <antoine.tenart@free-electrons•com>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons•com>,
"Gregory CLEMENT" <gregory.clement@free-electrons•com>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons•com>
Subject: Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support
Date: Wed, 3 Jan 2018 14:33:41 +0100 [thread overview]
Message-ID: <20180103133341.GJ15036@lunn.ch> (raw)
In-Reply-To: <CAPv3WKfZN+=9wFJ5ct+8nttd=bikaZ=Ei741pyTVXjQz2zq2dg@mail.gmail.com>
On Wed, Jan 03, 2018 at 02:13:09PM +0100, Marcin Wojtas wrote:
> Hi Andrew,
>
> 2018-01-03 13:47 GMT+01:00 Andrew Lunn <andrew@lunn•ch>:
> >> I already agreed with 'reg' being awkward in the later emails.
> >> Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus?
> >
> > Also, how do you specify which MDIO bus the PHY is on. To fully
> > specify a PHY, you need both bits of information.
> >
> > In DT, the phy-handle phandle can point to any PHY anywhere in the
> > system. This is particularly important when a Ethernet device has two
> > MDIO busses.
> >
>
> For now, my local MDIO bus description is pretty DT-like, i.e. master
> bus with children PHYs:
> Device (MDIO)
> {
> Name (_HID, "MRVL0100") //
> _HID: Hardware ID
> Name (_UID, 0x00) //
> _UID: Unique ID
> Name (_CRS, ResourceTemplate ()
> {
> Memory32Fixed (ReadWrite,
> 0xf212a200, // Address Base
> 0x00000010, //
> Address Length
> )
> })
> Device (GPHY)
> {
> Name (_ADR, 0x0)
> }
> }
>
> Device (XSMI)
> {
> Name (_HID, "MRVL0101") //
> _HID: Hardware ID
> Name (_UID, 0x00) //
> _UID: Unique ID
> Name (_CRS, ResourceTemplate ()
> {
> Memory32Fixed (ReadWrite,
> 0xf212a600, // Address Base
> 0x00000010, //
> Address Length
> )
> })
> Device (PHY0)
> {
> Name (_ADR, 0x0)
> Name (_CID, "ethernet-phy-ieee802.3-c45")
> }
> Device (PHY8)
> {
> Name (_ADR, 0x8)
> Name (_CID, "ethernet-phy-ieee802.3-c45")
> }
> }
>
> Which is referenced in the port's node:
>
> Package () { "phy", Package (){\_SB.XSMI.PHY0}},
Hi Marcin
This reference looks good, giving both the bus and the PHY on the bus.
I assume you can use references like this within the Device (PHY8)
node? You need to be able to reference a GPIO used for resetting the
PHY. And you also need to reference a GPIO at the Device (MDIO) level
for resetting all the PHYs on the MDIO bus.
Andrew
next prev parent reply other threads:[~2018-01-03 13:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 9:17 [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support Marcin Wojtas
2017-12-18 9:17 ` [net-next: PATCH 1/8] device property: Introduce fwnode_get_mac_address() Marcin Wojtas
2017-12-18 9:17 ` [net-next: PATCH 2/8] device property: Introduce fwnode_get_phy_mode() Marcin Wojtas
2017-12-18 9:17 ` [net-next: PATCH 3/8] mdio_bus: Introduce fwnode MDIO helpers Marcin Wojtas
2017-12-18 9:18 ` [net-next: PATCH 4/8] net: mvmdio: add ACPI support Marcin Wojtas
2017-12-18 9:18 ` [net-next: PATCH 5/8] net: mvpp2: simplify maintaining enabled ports' list Marcin Wojtas
2017-12-18 9:18 ` [net-next: PATCH 6/8] net: mvpp2: use device_*/fwnode_* APIs instead of of_* Marcin Wojtas
2017-12-18 9:18 ` [net-next: PATCH 7/8] net: mvpp2: handle PHY with its fwnode Marcin Wojtas
2017-12-18 9:18 ` [net-next: PATCH 8/8] net: mvpp2: enable ACPI support in the driver Marcin Wojtas
2017-12-18 9:40 ` [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support Ard Biesheuvel
2017-12-18 15:49 ` Marcin Wojtas
2018-01-03 11:00 ` Graeme Gregory
2018-01-03 11:12 ` Marcin Wojtas
2018-01-03 12:47 ` Andrew Lunn
2018-01-03 13:13 ` Marcin Wojtas
2018-01-03 13:33 ` Andrew Lunn [this message]
2018-01-03 13:36 ` Marcin Wojtas
2018-01-04 16:09 ` Graeme Gregory
2018-01-04 16:20 ` Andrew Lunn
2018-01-08 14:45 ` Graeme Gregory
2018-01-08 14:53 ` Andrew Lunn
2018-01-08 15:14 ` Graeme Gregory
2018-01-08 15:42 ` Andrew Lunn
2018-01-08 17:17 ` Marcin Wojtas
2018-01-09 10:19 ` Graeme Gregory
2018-01-09 10:22 ` Marcin Wojtas
2018-01-09 13:00 ` Andrew Lunn
2018-01-18 12:31 ` Lorenzo Pieralisi
2018-01-18 13:00 ` Andrew Lunn
2018-01-19 18:07 ` Marcin Wojtas
2018-01-19 18:53 ` Andrew Lunn
2018-01-20 19:52 ` Mika Westerberg
2018-01-21 1:08 ` Andrew Lunn
2018-01-21 10:27 ` Mika Westerberg
2018-01-21 16:13 ` Andrew Lunn
2018-01-21 17:13 ` Ard Biesheuvel
2018-01-21 18:55 ` Andrew Lunn
2017-12-18 14:09 ` Rafael J. Wysocki
2017-12-19 18:48 ` David Miller
2017-12-19 18:59 ` Marcin Wojtas
2017-12-19 20:46 ` Andrew Lunn
2017-12-19 23:13 ` Marcin Wojtas
2017-12-21 19:21 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103133341.GJ15036@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=antoine.tenart@free-electrons$(echo .)com \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=ezequiel.garcia@free-electrons$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=graeme.gregory@linaro$(echo .)org \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox