Subject: Re: [PATCH iproute2] devlink, rdma, tipc: properly define TARGETS without HAVE_MNL

From: Stephen Hemminger <[email-masked]>
Date: Fri, 5 Jan 2018 16:34:26 -0800

On Wed,  3 Jan 2018 16:28:52 +0100
Matthias Schiffer <[email-masked]> wrote:

> Leaving a variable with a generic name such as TARGETS undefined would lead
> to Make picking up its value from the environment. Avoid this by always
> defining TARGETS in the Makefiles.
> 
> Signed-off-by: Matthias Schiffer <[email-masked]>
> ---
> 
> I also noticed that many Makefiles refer to a variable LIBS, which is
> neither defined nor documented to be passed from the outside. Is this
> intentional?
> 
> 
>  devlink/Makefile | 4 +++-
>  rdma/Makefile    | 4 +++-
>  tipc/Makefile    | 4 +++-
>  3 files changed, 9 insertions(+), 3 deletions(-)

Applied.

Most of the Makefiles are very old.
There maybe other variable issues.