Subject: Re: [PATCH bpf-next 2/2] net: free RX queue structures

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 10 Jan 2018 11:59:11 +0100

On Wed, 10 Jan 2018 01:20:02 -0800
Jakub Kicinski <[email-masked]> wrote:

> Looks like commit e817f85652c1 ("xdp: generic XDP handling of
> xdp_rxq_info") replaced kvfree(dev->_rx) in free_netdev() with
> a call to netif_free_rx_queues() which doesn't actually free
> the rings?
> 
> While at it remove the unnecessary temporary variable.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Signed-off-by: Jakub Kicinski <[email-masked]>
> Reviewed-by: Simon Horman <[email-masked]>

Acked-by: Jesper Dangaard Brouer <[email-masked]>

Thanks for fixing this!

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer