From: Jiri Benc <jbenc@redhat•com>
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google•com>
Cc: liuqifa@huawei•com, David Miller <davem@davemloft•net>,
dsahern@gmail•com, mschiffer@universe-factory•net,
idosch@mellanox•com, fw@strlen•de, kjlx@templeofstupid•com,
girish.moodalbail@oracle•com, sainath.grandhi@intel•com,
linux-netdev <netdev@vger•kernel.org>,
weiyongjun1@huawei•com, chenweilong@huawei•com,
maowenan@huawei•com, wangyufen@huawei•com, yuehaibing@huawei•com,
liujian56@huawei•com, liuzhe24@huawei•com,
wangkefeng.wang@huawei•com, dingtianhong@huawei•com
Subject: Re: [PATCH V2] ipvlan: fix ipvlan MTU limits
Date: Fri, 12 Jan 2018 09:34:13 +0100 [thread overview]
Message-ID: <20180112093413.683560bf@redhat.com> (raw)
In-Reply-To: <CAF2d9ji5yj-M8etHVZU8WOUz8ivjyk=_y=obOOxG9OB3Vdk+wg@mail.gmail.com>
On Thu, 11 Jan 2018 08:59:58 -0800, Mahesh Bandewar (महेश बंडेवार) wrote:
> I guess the logic would be as simple as - if mtu_adj for a slave is
> set to 0, then it's
> following master otherwise not. By setting different mtu for a slave, you will
> set this mtu_adj a positive number which would mean it's not following master.
> So it's subjected to clamping when masters' mtu is reducing but should stay
> otherwise. Also when slave decides to follow master again, it can set the mtu
> to be same as masters' (making mtu_adj == 0) and then it would start following
> master again.
How can the mtu_adj value be queried and set from user space?
> Whether it's magic or not, it's the current behavior and I know several use
> cases depend on this behavior which would be broken otherwise. The
> approach I proposed keeps that going for those who depend on that while
> adds an ability to set mtu per slave for the use case mentioned in this
> patch-set too.
I don't think this works currently. When someone (does not have to be
you, it can be a management software running in background) sets the
MTU to the current value, the magic behavior is lost without any way to
restore it (unless I'm missing a way to restore it, see my question
above). So any user that depends on the magic behavior is broken anyway
even now.
Jiri
next prev parent reply other threads:[~2018-01-12 8:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 7:21 [PATCH V2] ipvlan: fix ipvlan MTU limits liuqifa
2018-01-11 2:09 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-11 11:25 ` Jiri Benc
2018-01-11 16:59 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-11 18:35 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-12 8:34 ` Jiri Benc [this message]
2018-01-12 8:48 ` Jiri Benc
2018-01-12 17:50 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-12 18:10 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112093413.683560bf@redhat.com \
--to=jbenc@redhat$(echo .)com \
--cc=chenweilong@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=girish.moodalbail@oracle$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=kjlx@templeofstupid$(echo .)com \
--cc=liujian56@huawei$(echo .)com \
--cc=liuqifa@huawei$(echo .)com \
--cc=liuzhe24@huawei$(echo .)com \
--cc=maheshb@google$(echo .)com \
--cc=maowenan@huawei$(echo .)com \
--cc=mschiffer@universe-factory$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sainath.grandhi@intel$(echo .)com \
--cc=wangkefeng.wang@huawei$(echo .)com \
--cc=wangyufen@huawei$(echo .)com \
--cc=weiyongjun1@huawei$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox