Subject: Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support

From: Jiri Benc <[email-masked]>
Date: Thu, 18 Jan 2018 11:13:49 +0100

Looks much better.

On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote:
> +	OVS_ERSPAN_OPT_IDX,	/* be32 index */

Why don't you convert this to u32 while passing to/from user space?

> +	[OVS_ERSPAN_OPT_IDX]	= { .len = sizeof(u32) },

sizeof(__be32) but see above.

Thanks,

 Jiri