From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: davem@davemloft•net, dsahern@gmail•com, netdev@vger•kernel.org,
oss-drivers@netronome•com
Subject: Re: [PATCH net-next 1/8] pkt_cls: add new tc cls helper to check offload flag and chain index
Date: Thu, 25 Jan 2018 11:26:52 -0800 [thread overview]
Message-ID: <20180125112652.2d604720@cakuba.netronome.com> (raw)
In-Reply-To: <20180125080348.GA2159@nanopsycho>
On Thu, 25 Jan 2018 09:03:48 +0100, Jiri Pirko wrote:
> >@@ -144,9 +144,6 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type,
> > return -EOPNOTSUPP;
> > }
> >
> >- if (cls_bpf->common.chain_index)
> >- return -EOPNOTSUPP;
> >-
>
> For nfp and netdevsim you do this in a patch that introduces the helper,
> for the rest you have a separate patch? Why this inconsistency?
> Again, from my perspective, this can be done in a single patch for all
> drivers. All the same hunks.
Ah, indeed, slightly sloppy. This patch used to remove the
tc_can_offload_extack() helper hence the conversion here.
Let me split them out.
next prev parent reply other threads:[~2018-01-25 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 0:17 [PATCH net-next 0/8] use tc_cls_can_offload_and_chain0() throughout the drivers Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 1/8] pkt_cls: add new tc cls helper to check offload flag and chain index Jakub Kicinski
2018-01-25 8:03 ` Jiri Pirko
2018-01-25 19:26 ` Jakub Kicinski [this message]
2018-01-25 15:41 ` Marcelo Ricardo Leitner
2018-01-25 19:25 ` Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 2/8] cxgb4: use tc_cls_can_offload_and_chain0() Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 3/8] mlx5: " Jakub Kicinski
2018-01-25 14:12 ` Or Gerlitz
2018-01-25 0:17 ` [PATCH net-next 4/8] bnxt: " Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 5/8] nfp: flower: " Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 6/8] ixgbe: " Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 7/8] mlxsw: " Jakub Kicinski
2018-01-25 0:17 ` [PATCH net-next 8/8] selftests/bpf: check for spurious extacks from the driver Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125112652.2d604720@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox