From: Roman Gushchin <guro@fb•com>
To: Eric Dumazet <edumazet@google•com>
Cc: "David S. Miller" <davem@davemloft•net>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>, <kernel-team@fb•com>,
<edumazet@google•com>, <hannes@cmpxchg•org>, <tj@kernel•org>
Subject: Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()
Date: Thu, 1 Feb 2018 20:22:04 +0000 [thread overview]
Message-ID: <20180201202158.GA11477@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <20180201.101655.1316424669256047119.davem@davemloft.net>
On Thu, Feb 01, 2018 at 10:16:55AM -0500, David Miller wrote:
> From: Roman Gushchin <guro@fb•com>
> Date: Wed, 31 Jan 2018 21:54:08 +0000
>
> > So I really start thinking that reverting 9f1c2674b328
> > ("net: memcontrol: defer call to mem_cgroup_sk_alloc()")
> > and fixing the original issue differently might be easier
> > and a proper way to go. Does it makes sense?
>
> You'll need to work that out with Eric Dumazet who added the
> change in question which you think we should revert.
Eric,
can you, please, provide some details about the use-after-free problem
that you've fixed with commit 9f1c2674b328 ("net: memcontrol: defer call
to mem_cgroup_sk_alloc()" ? Do you know how to reproduce it?
Deferring mem_cgroup_sk_alloc() breaks socket memory accounting
and makes it much more fragile in general. So, I wonder, if there are
solutions for the use-after-free problem.
Thank you!
Roman
next prev parent reply other threads:[~2018-02-01 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 0:19 [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc() Roman Gushchin
2018-01-25 17:03 ` David Miller
2018-01-25 17:15 ` Roman Gushchin
2018-01-31 21:54 ` Roman Gushchin
2018-02-01 15:16 ` David Miller
2018-02-01 20:22 ` Roman Gushchin [this message]
2018-02-01 21:17 ` Eric Dumazet
2018-02-01 22:55 ` Roman Gushchin
2018-02-01 23:27 ` Eric Dumazet
2018-02-01 23:42 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201202158.GA11477@castle.DHCP.thefacebook.com \
--to=guro@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hannes@cmpxchg$(echo .)org \
--cc=kernel-team@fb$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox