Subject: Re: [PATCH] ss: prepare rth when killing inet sock

From: Stephen Hemminger <[email-masked]>
Date: Wed, 14 Feb 2018 07:25:27 -0800

On Wed, 14 Feb 2018 22:50:04 +0900
Masatake YAMATO <[email-masked]> wrote:

> kill_inet_sock() expects rhn_handle instance is passed
> via inet_diag_arg argument. However on the following calling path:
> 
>     generic_show_sock
>     => show_one_inet_sock
>        => kill_inet_sock  
> 
> rth field of inet_diag_arg is not filled with the address of
> rhn_handle instance. As the result ss crashes.
> 
> This commit fills the field with newly created rhn_handle
> instance.
> 
> Signed-off-by: Masatake YAMATO <[email-masked]>

Won't this slow down ss because it does open/close of netlink socket
for each socket being displayed.  It is not uncommon to run this with
millions of sockets open.