From: Rahul Lakkireddy <rahul.lakkireddy@chelsio•com>
To: David Miller <davem@davemloft•net>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Ganesh GR <ganeshgr@chelsio•com>,
Nirranjan Kirubaharan <nirranjan@chelsio•com>,
Indranil Choudhury <indranil@chelsio•com>
Subject: Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic
Date: Mon, 19 Feb 2018 18:04:17 +0530 [thread overview]
Message-ID: <20180219123416.GA7737@chelsio.com> (raw)
In-Reply-To: <20180216.154101.1707041533181015167.davem@davemloft.net>
On Saturday, February 02/17/18, 2018 at 02:11:01 +0530, David Miller wrote:
> From: Rahul Lakkireddy <rahul.lakkireddy@chelsio•com>
> Date: Thu, 15 Feb 2018 19:24:42 +0530
>
> > Register callback to panic_notifier_list. Invoke dump collect routine
> > to append dump to vmcore.
> >
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio•com>
> > Signed-off-by: Ganesh Goudar <ganeshgr@chelsio•com>
>
> There is absolutely no precedence for a networking driver dumping
> things into the vmcore image on a panic.
>
> And I don't think this is a good idea.
>
> Really, this commit message should have explained why this is desired
> and in what context it is legitimate for this driver in particular
> to do it.
>
> A very detailed, long, complete commit message is especially important
> when you are deciding to blaze you own trail and do something no other
> networking driver has done before.
>
My mistake. Will add more info in the commit message in v2.
> I get really upset when I see changes like this, because you give me
> no preparation for what I'm about to read in the patch and therefore
> I have to go into this routine asking you to explain things properly.
>
> But as-is, I see this panic notifier as a really bad idea.
>
Our requirement is to analyze the state of firmware/hardware at the
time of kernel panic. The dump will be written to pre allocated
buffer during kernel panic, which can be extracted later from the
vmcore, for post-analysis.
Panic notifier seemed to meet our requirement, as we are able to
collect dump during kernel panic and then extract it from vmcore.
Please suggest, if this can be done in a better way.
Thanks,
Rahul
next prev parent reply other threads:[~2018-02-19 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 13:54 [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic Rahul Lakkireddy
2018-02-16 20:41 ` David Miller
2018-02-19 12:34 ` Rahul Lakkireddy [this message]
2018-02-19 15:01 ` David Miller
2018-02-21 0:43 ` Jakub Kicinski
2018-02-21 0:51 ` Florian Fainelli
2018-02-21 1:04 ` Jakub Kicinski
2018-02-21 15:25 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219123416.GA7737@chelsio.com \
--to=rahul.lakkireddy@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=indranil@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nirranjan@chelsio$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox