From: Andrew Lunn <andrew@lunn•ch>
To: Bryan.Whitehead@microchip•com
Cc: davem@davemloft•net, UNGLinuxDriver@microchip•com,
netdev@vger•kernel.org
Subject: Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver
Date: Thu, 22 Feb 2018 22:47:32 +0100 [thread overview]
Message-ID: <20180222214732.GJ28112@lunn.ch> (raw)
In-Reply-To: <20180222214534.GI28112@lunn.ch>
On Thu, Feb 22, 2018 at 10:45:34PM +0100, Andrew Lunn wrote:
> > Also I'm allocating interrupt resources on interface up, and freeing resources
> > on interface down. So if there is an up, down, up sequence then the driver
> > will allocate resources twice. In order for devm to work properly, should I
> > move all resource allocation into the probe function?
>
> Hi Bryan
>
> It is better to fail early if the resource is not available, so yes, i
> would register the interrupt handler in probe.
And we maintainers don't always agree with each other :-)
Doing irq handling in open/close without devm_ is also O.K.
Andrew
next prev parent reply other threads:[~2018-02-22 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 19:06 [PATCH v2 net-next 0/2] lan743x: Add new lan743x driver Bryan Whitehead
2018-02-21 19:06 ` [PATCH v2 net-next 1/2] lan743x: Add main source files for " Bryan Whitehead
2018-02-22 2:55 ` Andrew Lunn
2018-02-22 21:31 ` Bryan.Whitehead
2018-02-22 21:43 ` Florian Fainelli
2018-02-22 21:45 ` Andrew Lunn
2018-02-22 21:47 ` Andrew Lunn [this message]
2018-02-22 22:10 ` Bryan.Whitehead
2018-02-22 18:02 ` kbuild test robot
2018-02-22 18:02 ` [RFC PATCH] lan743x: lan743x_csr_read() can be static kbuild test robot
2018-02-22 22:08 ` [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver Florian Fainelli
2018-02-23 22:44 ` Bryan.Whitehead
2018-02-24 2:06 ` Andrew Lunn
2018-02-26 5:41 ` Bryan.Whitehead
2018-02-26 17:25 ` Andrew Lunn
2018-02-26 17:35 ` Bryan.Whitehead
2018-02-21 19:06 ` [PATCH v2 net-next 2/2] lan743x: Update MAINTAINERS to include " Bryan Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222214732.GJ28112@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Bryan.Whitehead@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox