Subject: Re: [PATCH iproute2 6/7] devlink: Add support for resource/dpipe relation

From: Stephen Hemminger <[email-masked]>
Date: Fri, 23 Feb 2018 08:40:17 -0800

On Wed, 14 Feb 2018 10:55:21 +0200
Arkadi Sharshevsky <[email-masked]> wrote:

> @@ -3457,15 +3509,36 @@ static int dpipe_table_show(struct dpipe_ctx *ctx, struct nlattr *nl)
>  		return -EINVAL;
>  	}
>  
> -	name = mnl_attr_get_str(nla_table[DEVLINK_ATTR_DPIPE_TABLE_NAME]);
> +	table = dpipe_table_alloc();
> +	if (!table)
> +		return -ENOMEM;
> +
> +	table->name = strdup(mnl_attr_get_str(nla_table[DEVLINK_ATTR_DPIPE_TABLE_NAME]));
>  	size = mnl_attr_get_u32(nla_table[DEVLINK_ATTR_DPIPE_TABLE_SIZE]);
>  	counters_enabled = !!mnl_attr_get_u8(nla_table[DEVLINK_ATTR_DPIPE_TABLE_COUNTERS_ENABLED]);

The use of long variable names in devlink is making for very long lines.
Please consider adopting a more concise style in future revisions.

Je n’ai fait celle-ci plus longue que parce que je n’ai pas eu le loisir de la faire plus courte.