Subject: Re: [v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

From: Kalle Valo <[email-masked]>
Date: Tue, 27 Feb 2018 16:17:46 +0000 (UTC)

Matthias Kaehlcke <[email-masked]> wrote:

> In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
> is assigned to itself in an if ... else statement, apparently only to
> document that the branch condition is handled and that a previously read
> value should be returned unmodified. The self-assignment causes clang to
> raise the following warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
>   error: explicitly assigning value of variable of type 'u32'
>     (aka 'unsigned int') to itself [-Werror,-Wself-assign]
>   writeVal = writeVal;
> 
> Delete the branch with the self-assignment.
> 
> Signed-off-by: Matthias Kaehlcke <[email-masked]>
> Acked-by: Larry Finger <[email-masked]>
> Reviewed-by: Guenter Roeck <[email-masked]>

Patch applied to wireless-drivers-next.git, thanks.

fb239c1209bb rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

-- 
https://patchwork.kernel.org/patch/10208183/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches