From: Antoine Tenart <antoine.tenart@bootlin•com>
To: David Miller <davem@davemloft•net>
Cc: antoine.tenart@bootlin•com, ymarkman@marvell•com,
mw@semihalf•com, stefanc@marvell•com,
thomas.petazzoni@free-electrons•com,
gregory.clement@free-electrons•com,
miquel.raynal@free-electrons•com, nadavh@marvell•com,
maxime.chevallier@bootlin•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds
Date: Tue, 27 Feb 2018 18:13:52 +0100 [thread overview]
Message-ID: <20180227171352.GD21643@kwain> (raw)
In-Reply-To: <20180227.111306.790069240486489244.davem@davemloft.net>
Hi David,
On Tue, Feb 27, 2018 at 11:13:06AM -0500, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@bootlin•com>
> > From: Yan Markman <ymarkman@marvell•com>
> > -#define MVPP2_MAX_TSO_SEGS 300
> > +#define MVPP2_MAX_TSO_SEGS 100
> > #define MVPP2_MAX_SKB_DESCS (MVPP2_MAX_TSO_SEGS * 2 + MAX_SKB_FRAGS)
> >
> > /* Dfault number of RXQs in use */
> > @@ -5810,7 +5810,7 @@ static int mvpp2_txq_init(struct mvpp2_port *port,
> > txq_pcpu->tso_headers = NULL;
> >
> > txq_pcpu->stop_threshold = txq->size - MVPP2_MAX_SKB_DESCS;
> > - txq_pcpu->wake_threshold = txq_pcpu->stop_threshold / 2;
> > + txq_pcpu->wake_threshold = txq_pcpu->stop_threshold - 100;
> >
>
> This number 100 is a magic constant. If it is related to
> MVPP2_MAX_TSO_SEGS, please use that define. Otherwise
> define a new one which is descriptive.
I agree. I'll ask Yan about it and update if possible.
Thanks!
Antoine
--
Antoine Ténart, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-02-27 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 14:14 [PATCH net-next 1/3] net: mvpp2: avoid checking for free aggregated descriptors twice Antoine Tenart
2018-02-26 14:14 ` [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds Antoine Tenart
2018-02-27 16:13 ` David Miller
2018-02-27 17:13 ` Antoine Tenart [this message]
2018-02-27 17:48 ` Yan Markman
2018-02-26 14:14 ` [PATCH net-next 3/3] net: mvpp2: align the ethtool ops definition Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227171352.GD21643@kwain \
--to=antoine.tenart@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=miquel.raynal@free-electrons$(echo .)com \
--cc=mw@semihalf$(echo .)com \
--cc=nadavh@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stefanc@marvell$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
--cc=ymarkman@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox