Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures

From: Jiri Benc <[email-masked]>
Date: Tue, 27 Feb 2018 20:42:35 +0100

On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote:
>  	if (port_dev->flags & IFF_LOOPBACK) {
> +		NL_SET_ERR_MSG(extack, "Loopback device can't be added as a team port");
>  		netdev_err(dev, "Device %s is loopback device. Loopback devices can't be added as a team port\n",
>  			   portname);

Aren't the netdev_errs unnecessary now?

Or do you keep them for people using old config tools with a new kernel?
If so, for how long? They should certainly be removed eventually. How
do we ensure we don't forget?

Seems to me it would be better to remove them right now.

Thanks,

 Jiri