Subject: Re: [PATCH net-next 1/5] selftests: forwarding: Only check tc version for tc tests

From: Ido Schimmel <[email-masked]>
Date: Thu, 1 Mar 2018 22:12:09 +0200

On Thu, Mar 01, 2018 at 11:09:43AM -0800, David Ahern wrote:
> Capabilities of tc command are irrelevant for router tests:
>     $ ./router.sh
>     SKIP: iproute2 too old, missing shared block support
> 
> Add a CHECK_TC flag and only check tc capabilities if set. Add flag to
> tc_common.sh and have it sourced before lib.sh
> 
> Also, if the command lacks some feature the test should exit non-0.
> 
> Signed-off-by: David Ahern <[email-masked]>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh      | 29 ++++++++++++++--------
>  .../testing/selftests/net/forwarding/tc_actions.sh |  2 +-
>  .../testing/selftests/net/forwarding/tc_chains.sh  |  2 +-
>  .../testing/selftests/net/forwarding/tc_common.sh  |  2 ++
>  .../testing/selftests/net/forwarding/tc_flower.sh  |  2 +-
>  .../selftests/net/forwarding/tc_shblocks.sh        |  2 +-

bridge_vlan_aware.sh also uses tc to check flooding and learning. Looks
good otherwise.

Reviewed-by: Ido Schimmel <[email-masked]>

Thanks, David!