From: Greg KH <gregkh@linuxfoundation•org>
To: Arushi Singhal <arushisinghal19971997@gmail•com>
Cc: devel@driverdev•osuosl.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, outreachy-kernel@googlegroups•com
Subject: Re: [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
Date: Sun, 4 Mar 2018 14:29:01 +0100 [thread overview]
Message-ID: <20180304132901.GA4222@kroah.com> (raw)
In-Reply-To: <20180304085935.GA20591@seema-Inspiron-15-3567>
On Sun, Mar 04, 2018 at 02:29:35PM +0530, Arushi Singhal wrote:
> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> Replace printks having a log level with the appropriate pr_*() macros.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail•com>
> ---
> drivers/staging/ipx/af_ipx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
> index d21a9d1..27f4461 100644
> --- a/drivers/staging/ipx/af_ipx.c
> +++ b/drivers/staging/ipx/af_ipx.c
> @@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc,
> intrfc->if_netnum = cb->ipx_source_net;
> ipxitf_add_local_route(intrfc);
> } else {
> - printk(KERN_WARNING "IPX: Network number collision "
> + pr_warn("IPX: Network number collision "
It is a driver, so it would be best to use dev_warn() or even better
yet, net_warn(). Please try to make that change instead.
thanks,
greg k-h
prev parent reply other threads:[~2018-03-04 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 8:59 [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro Arushi Singhal
2018-03-04 13:29 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180304132901.GA4222@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=arushisinghal19971997@gmail$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=outreachy-kernel@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox