From: Guillaume Nault <g.nault@alphalink•fr>
To: Paolo Abeni <pabeni@redhat•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
James Chapman <jchapman@katalix•com>,
Wei Wang <weiwan@google•com>, David Ahern <dsahern@gmail•com>
Subject: Re: [PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses
Date: Mon, 12 Mar 2018 18:11:00 +0100 [thread overview]
Message-ID: <20180312171100.GG1351@alphalink.fr> (raw)
In-Reply-To: <1520844798.2585.13.camel@redhat.com>
On Mon, Mar 12, 2018 at 09:53:18AM +0100, Paolo Abeni wrote:
> On Fri, 2018-03-09 at 19:26 +0100, Guillaume Nault wrote:
> > On Fri, Mar 09, 2018 at 06:58:00PM +0100, Paolo Abeni wrote:
> > > The single threaded reproducer does not trigger anymore after 1/2,
> > > _but_ if ask syzbot to test 1/2 that will trigger another splat,
> > > because syzbot will do also multi threaded tests and we will hit the
> > > race between connect(tunnel->fd) and l2tp_tunnel_create(),
> > >
> >
> > Ok, and this case is handled by the sk_state test in l2tp_xmit_skb(),
> > right?
>
> We need both such test and checking for v4mapped address in
> l2tp_xmit_skb()
>
> > I just want to be sure that I didn't miss anything and that patch 1/2
> > combined with the socket state check in l2tp_xmit_skb() are enough to
> > fix the bug. And that overriding ->inet_*addr can be removed entirely
> > (and safely!).
>
> I tested the above in vs the repro and in some real use case, but any
> additinal pair of eyes are welcome!
>
It looks good to me too. I think everything is cleared up now.
Nice work!
prev parent reply other threads:[~2018-03-12 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 9:30 [PATCH net v2 0/2] l2tp: fix races with ipv4-mapped ipv6 addresses Paolo Abeni
2018-03-09 9:30 ` [PATCH net v2 1/2] net: ipv6: keep sk status consistent after datagram connect failure Paolo Abeni
2018-03-09 9:30 ` [PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses Paolo Abeni
2018-03-09 16:43 ` Guillaume Nault
2018-03-09 17:04 ` Paolo Abeni
2018-03-09 17:47 ` Guillaume Nault
2018-03-09 17:58 ` Paolo Abeni
2018-03-09 18:26 ` Guillaume Nault
2018-03-12 8:53 ` Paolo Abeni
2018-03-12 17:11 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312171100.GG1351@alphalink.fr \
--to=g.nault@alphalink$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=jchapman@katalix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=weiwan@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox