From: Andrew Lunn <andrew@lunn•ch>
To: Brad Mouring <brad.mouring@ni•com>
Cc: Nicolas Ferre <nicolas.ferre@microchip•com>,
Rob Herring <robh+dt@kernel•org>,
"David S . Miller" <davem@davemloft•net>,
Michael Grzeschik <m.grzeschik@pengutronix•de>,
Mark Rutland <mark.rutland@arm•com>,
netdev@vger•kernel.org, Julia Cartwright <julia@ni•com>,
devicetree@vger•kernel.org
Subject: Re: [PATCH v3 net-next 3/4] net: macb: Add phy-handle DT support
Date: Mon, 12 Mar 2018 18:59:56 +0100 [thread overview]
Message-ID: <20180312175956.GS27783@lunn.ch> (raw)
In-Reply-To: <20180312171001.129209-4-brad.mouring@ni.com>
> @@ -488,6 +488,9 @@ static int macb_mii_probe(struct net_device *dev)
> }
> bp->phy_node = of_node_get(np);
> } else {
> + /* attempt to find a phy-handle */
> + bp->phy_node = of_parse_phandle(np, "phy-handle", 0);
> +
Hi Brad
It seems like you should check the return value here, any only
continue with the fallback if there was not a phy-handle.
> /* fallback to standard phy registration if no phy were
> * found during dt phy registration
> */
Andrew
next prev parent reply other threads:[~2018-03-12 18:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 22:42 [PATCH 1/2] net: macb: Add phy-handle DT support Brad Mouring
2018-03-07 22:42 ` [PATCH 2/2] Documentation: macb: Document phy-handle optional binding Brad Mouring
2018-03-08 17:32 ` [1/2] net: macb: Add phy-handle DT support Andrew Lunn
2018-03-08 22:00 ` Brad Mouring
2018-03-09 22:12 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-09 22:12 ` [PATCH v2 net-next 2/3] net: macb: Add phy-handle DT support Brad Mouring
2018-03-09 22:12 ` [PATCH v2 net-next 3/3] Documentation: macb: Document phy-handle optional binding Brad Mouring
2018-03-10 16:18 ` Andrew Lunn
2018-03-10 16:17 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup Andrew Lunn
2018-03-10 22:19 ` Brad Mouring
2018-03-12 17:09 ` [PATCH v3 net-next 0/4] macb: Introduce phy-handle DT functionality Brad Mouring
2018-03-12 17:09 ` [PATCH v3 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-12 17:17 ` Florian Fainelli
2018-03-13 4:25 ` kbuild test robot
2018-03-12 17:09 ` [PATCH v3 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring
2018-03-12 17:17 ` Florian Fainelli
2018-03-12 17:10 ` [PATCH v3 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring
2018-03-12 17:59 ` Andrew Lunn [this message]
2018-03-12 21:34 ` [PATCH v4 net-next 0/4] Brad Mouring
2018-03-12 21:34 ` [PATCH v4 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-12 21:34 ` [PATCH v4 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring
2018-03-12 21:34 ` [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring
2018-03-12 21:57 ` Andrew Lunn
2018-03-12 22:30 ` Florian Fainelli
2018-03-13 13:49 ` Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 1/4] net: macb: Reorganize macb_mii bringup Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 2/4] net: macb: Remove redundant poll irq assignment Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 3/4] net: macb: Add phy-handle DT support Brad Mouring
2018-03-13 21:32 ` [PATCH v5 net-next 4/4] Documentation: macb: Document phy-handle binding Brad Mouring
2018-03-16 15:15 ` [PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality David Miller
2018-03-12 21:34 ` [PATCH v4 net-next 4/4] Documentation: macb: Document phy-handle binding Brad Mouring
2018-03-12 17:10 ` [PATCH v3 " Brad Mouring
2018-03-12 17:18 ` Florian Fainelli
2018-03-11 7:02 ` [PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312175956.GS27783@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=brad.mouring@ni$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=julia@ni$(echo .)com \
--cc=m.grzeschik@pengutronix$(echo .)de \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox