From: Al Viro <viro@ZenIV•linux.org.uk>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, linux-sctp@vger•kernel.org
Subject: Re: sctp: use proc_remove_subtree()
Date: Fri, 16 Mar 2018 23:33:07 +0000 [thread overview]
Message-ID: <20180316233307.GK30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180316.124415.427695020359988885.davem@davemloft.net>
On Fri, Mar 16, 2018 at 12:44:15PM -0400, David Miller wrote:
> From: Al Viro <viro@ZenIV•linux.org.uk>
> Date: Wed, 14 Mar 2018 20:51:19 +0000
>
> > On Wed, Mar 14, 2018 at 08:46:21PM +0000, Al Viro wrote:
> >> use proc_remove_subtree() for subtree removal, both on setup failure
> >> halfway through and on teardown. No need to make simple things
> >> complex...
> >
> > ... and sctp_dbg_objcnt_exit() can be removed as well - remove_proc_subtree()
> > will get that sucker automatically. Either a trivial addition, or equally
> > trivial followup...
>
> Please add it to this patch and resubmit.
Done...
next prev parent reply other threads:[~2018-03-16 23:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 20:46 sctp: use proc_remove_subtree() Al Viro
2018-03-14 20:51 ` Al Viro
2018-03-16 16:44 ` David Miller
2018-03-16 23:33 ` Al Viro [this message]
2018-03-16 23:32 ` [PATCH v2] " Al Viro
2018-03-18 0:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316233307.GK30522@ZenIV.linux.org.uk \
--to=viro@zeniv$(echo .)linux.org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox