Subject: Re: [PATCH v12 net-next 06/12] crypto: chtls - structure and macro for Inline TLS

From: Stefano Brivio <[email-masked]>
Date: Mon, 19 Mar 2018 18:02:49 +0100

On Mon, 19 Mar 2018 19:25:39 +0530
Atul Gupta <[email-masked]> wrote:

> +#define SOCK_INLINE (31)
>
> [...]
>
> +static inline int csk_flag(const struct sock *sk, enum csk_flags flag)
> +{
> +	struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
> +
> +	if (!sock_flag(sk, SOCK_INLINE))
> +		return 0;

Please take care of the comments.

I understand this series is big and you might be tempted to minimize
your effort in the hope that reviewers will fail to check that you
addressed their concerns.

You are also succeeding in making it hard by re-posting so quickly,
addressing a few "easy" comments at a time, without taking care of the
change log.

But still I believe your hopes are not so reasonably founded.

-- 
Stefano