From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Russell King <rmk+kernel@armlinux•org.uk>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [RFC net-next] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool
Date: Mon, 19 Mar 2018 21:39:23 +0100 [thread overview]
Message-ID: <20180319203923.GD1607@lunn.ch> (raw)
In-Reply-To: <a3b7907a-d7b7-093a-20c5-21beb982e825@gmail.com>
On Mon, Mar 19, 2018 at 12:20:32PM -0700, Florian Fainelli wrote:
> On 12/17/2017 06:48 AM, Russell King wrote:
> > Provide a pointer to the SFP bus in struct net_device, so that the
> > ethtool module EEPROM methods can access the SFP directly, rather
> > than needing every user to provide a hook for it.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux•org.uk>
> > ---
> > Questions:
> > 1. Is it worth adding a pointer to struct net_device for these two
> > methods, rather than having multiple duplicate veneers to vector
> > the ethtool module EEPROM ioctls through to the SFP bus layer?
>
> Considering the negative diffstat and the fact that it solves real
> problems for you, I would say yes.
We have also received a bunch of patches removing the phydev pointer
for driver private structures and making use of the net_device one. It
would be nice to avoid the same with phylink.
Andrew
prev parent reply other threads:[~2018-03-19 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 14:48 [RFC net-next] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool Russell King
2017-12-17 17:06 ` Russell King - ARM Linux
2017-12-17 18:29 ` Andrew Lunn
2017-12-17 19:26 ` Russell King - ARM Linux
2018-03-19 19:20 ` Florian Fainelli
2018-03-19 20:39 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319203923.GD1607@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox