From: Rahul Lakkireddy <rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>
To: Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public•gmane.org>
Cc: Indranil Choudhury
<indranil-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Nirranjan Kirubaharan
<nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>,
"kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org"
<kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public•gmane.org"
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public•gmane.org>,
Ganesh GR <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>,
"viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public•gmane.org"
<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public•gmane.org>,
"linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>,
"torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org"
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
"ebiederm-aS9lmoZGLiVWk0Htik3J/w@public•gmane.org"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public•gmane.org>
Subject: Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel
Date: Fri, 30 Mar 2018 16:21:57 +0530 [thread overview]
Message-ID: <20180330105156.GA24344@chelsio.com> (raw)
In-Reply-To: <20180330103907.GC3313@nanopsycho>
On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote:
> Sat, Mar 24, 2018 at 11:56:33AM CET, rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org wrote:
> >Add a new module crashdd that exports the /sys/kernel/crashdd/
> >directory in second kernel, containing collected hardware/firmware
> >dumps.
> >
> >The sequence of actions done by device drivers to append their device
> >specific hardware/firmware logs to /sys/kernel/crashdd/ directory are
> >as follows:
> >
> >1. During probe (before hardware is initialized), device drivers
> >register to the crashdd module (via crashdd_add_dump()), with
> >callback function, along with buffer size and log name needed for
> >firmware/hardware log collection.
> >
> >2. Crashdd creates a driver's directory under
> >/sys/kernel/crashdd/<driver>. Then, it allocates the buffer with
>
> This smells. I need to identify the exact ASIC instance that produced
> the dump. To identify by driver name does not help me if I have multiple
> instances of the same driver. This looks wrong to me. This looks like
> a job for devlink where you have 1 devlink instance per 1 ASIC instance.
>
> Please see:
> http://patchwork.ozlabs.org/project/netdev/list/?series=36524
>
> I bevieve that the solution in the patchset could be used for
> your usecase too.
>
>
The sysfs approach proposed here had been dropped in favour exporting
the dumps as ELF notes in /proc/vmcore.
Will be posting the new patches soon.
> >requested size and invokes the device driver's registered callback
> >function.
> >
> >3. Device driver collects all hardware/firmware logs into the buffer
> >and returns control back to crashdd.
> >
> >4. Crashdd exposes the buffer as a binary file via
> >/sys/kernel/crashdd/<driver>/<dump_file>.
> >
next prev parent reply other threads:[~2018-03-30 10:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 10:56 [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel Rahul Lakkireddy
[not found] ` <cover.1521888444.git.rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2018-03-24 10:56 ` [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel Rahul Lakkireddy
2018-03-25 12:43 ` kbuild test robot
2018-03-30 10:39 ` Jiri Pirko
2018-03-30 10:51 ` Rahul Lakkireddy [this message]
2018-03-30 18:42 ` Eric W. Biederman
2018-04-02 9:11 ` Jiri Pirko
2018-04-02 12:21 ` Andrew Lunn
2018-04-02 12:30 ` Rahul Lakkireddy
2018-04-03 7:04 ` Jiri Pirko
2018-03-30 15:11 ` Andrew Lunn
2018-04-02 9:12 ` Jiri Pirko
2018-04-03 5:43 ` Alex Vesker
2018-04-03 12:35 ` Andrew Lunn
2018-03-24 10:56 ` [PATCH net-next v2 2/2] cxgb4: " Rahul Lakkireddy
2018-03-24 15:18 ` Andrew Lunn
[not found] ` <f06cca21650affa10d83a28dbd7fb577792e35a9.1521888444.git.rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2018-03-24 22:18 ` Thadeu Lima de Souza Cascardo
2018-03-25 0:17 ` Eric W. Biederman
2018-03-24 15:20 ` [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel Eric W. Biederman
2018-03-26 13:45 ` Rahul Lakkireddy
2018-03-27 13:17 ` Eric W. Biederman
2018-03-27 15:27 ` Rahul Lakkireddy
2018-03-27 15:59 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330105156.GA24344@chelsio.com \
--to=rahul.lakkireddy-ut6up61k2wzbdgjk7y7tuq@public$(echo .)gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=indranil-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public$(echo .)gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public$(echo .)gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox