Subject: Re: [net-next V9 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 4 Apr 2018 15:36:37 +0200

On Wed, 4 Apr 2018 16:12:14 +0300
Tariq Toukan <[email-masked]> wrote:

> > @@ -432,9 +434,12 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,
> >   
> >   	rq->buff.map_dir = rq->xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE;
> >   	rq->buff.headroom = mlx5e_get_rq_headroom(mdev, params);
> > +	pool_size = 1 << params->log_rq_mtu_frames;
> >   
> >   	switch (rq->wq_type) {
> >   	case MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ:
> > +
> > +		pool_size = pool_size * MLX5_MPWRQ_PAGES_PER_WQE;  
> 
> For rq->wq_type != MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ, please use:
> pool_size = 1 << params->log_rq_mtu_frames;
> 
> For rq->wq_type == MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ, please use:
> pool_size = MLX5_MPWRQ_PAGES_PER_WQ * mlx5e_mpwqe_get_log_rq_size(params);

Okay, fixed.  Ready for V10, when net-next opens again...

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer