From: gregkh <gregkh@linuxfoundation•org>
To: Laurentiu Tudor <laurentiu.tudor@nxp•com>
Cc: Andrew Lunn <andrew@lunn•ch>, Stuart Yoder <stuyoder@gmail•com>,
Arnd Bergmann <arnd@arndb•de>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp•com>,
Razvan Stefanescu <razvan.stefanescu@nxp•com>,
Roy Pledge <roy.pledge@nxp•com>,
Networking <netdev@vger•kernel.org>
Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
Date: Thu, 5 Apr 2018 14:30:18 +0200 [thread overview]
Message-ID: <20180405123018.GA17751@kroah.com> (raw)
In-Reply-To: <5AC5FAA8.80409@nxp.com>
On Thu, Apr 05, 2018 at 10:30:01AM +0000, Laurentiu Tudor wrote:
> Hello,
>
> My 2c below.
>
> On 04/04/2018 03:42 PM, Andrew Lunn wrote:
> >> I hear you. It is more complicated this way...having all these individual
> >> objects vs just a single "bundle" of them that represents a NIC. But, that's
> >> the way the DPAA2 hardware is, and we're implementing kernel support for
> >> the hardware as it is.
> >
> > Hi Stuart
> >
> > I see we are not making any progress here.
> >
> > So what i suggest is you post the kernel code and configuration tool
> > concept to netdev for a full review. You want reviews from David
> > Miller, Jiri Pirko, Jakub Kicinski, David Ahern, etc.
> >
>
> I think that the discussion steered too much towards networking related
> topics, while this ioctl doesn't have much to do with networking.
> It's just an ioctl for our mc-bus bus driver that is used to manage the
> devices on this bus through userspace tools.
> In addition, I'd drop any mention of our reference user space app
> (restool) to emphasize that this ioctl is not added just for a
> particular user space app. I think Stuart also mentioned this.
I'm not going to take a "generic device configuration ioctl" patch
unless it is documented to all exactly what it does, and why it is
there.
thanks,
greg k-h
next prev parent reply other threads:[~2018-04-05 12:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1521818402.git.ioana.ciornei@nxp.com>
[not found] ` <d8c243a9ead2fe1375dee242aec26d1276129409.1521818402.git.ioana.ciornei@nxp.com>
[not found] ` <CAK8P3a089ZiPdp1CcVct8Kac+ejkNP8TrVpWYSr_nMGo4goO1Q@mail.gmail.com>
[not found] ` <HE1PR04MB32126A07A4B4CC7225E661E4E0A30@HE1PR04MB3212.eurprd04.prod.outlook.com>
2018-03-28 15:43 ` [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Arnd Bergmann
2018-03-28 16:28 ` Andrew Lunn
2018-04-02 13:24 ` Ioana Ciornei
2018-04-02 13:44 ` Andrew Lunn
2018-04-03 11:12 ` Razvan Stefanescu
2018-04-03 13:04 ` Andrew Lunn
2018-04-03 23:57 ` Stuart Yoder
2018-04-04 1:05 ` Andrew Lunn
2018-04-04 3:22 ` Stuart Yoder
2018-04-04 12:42 ` Andrew Lunn
2018-04-05 4:24 ` Stuart Yoder
2018-04-05 10:30 ` Laurentiu Tudor
2018-04-05 11:47 ` Andrew Lunn
2018-04-05 12:16 ` Laurentiu Tudor
2018-04-05 12:48 ` Andrew Lunn
2018-04-05 14:43 ` Laurentiu Tudor
2018-04-05 15:23 ` Andrew Lunn
2018-04-05 15:35 ` Ruxandra Ioana Ciocoi Radulescu
2018-04-05 16:12 ` gregkh
2018-04-05 16:56 ` Andrew Lunn
2018-04-05 12:30 ` gregkh [this message]
2018-04-05 14:09 ` Laurentiu Tudor
2018-04-05 14:19 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405123018.GA17751@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=laurentiu.tudor@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=razvan.stefanescu@nxp$(echo .)com \
--cc=roy.pledge@nxp$(echo .)com \
--cc=ruxandra.radulescu@nxp$(echo .)com \
--cc=stuyoder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox