From: Andrew Lunn <andrew@lunn•ch>
To: Phil Elwell <phil@raspberrypi•org>
Cc: Woojung Huh <woojung.huh@microchip•com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip•com>,
Rob Herring <robh+dt@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
"David S. Miller" <davem@davemloft•net>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Linus Walleij <linus.walleij@linaro•org>,
Andrew Morton <akpm@linux-foundation•org>,
Randy Dunlap <rdunlap@infradead•org>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-usb@vger•kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: Document the DT bindings for lan78xx
Date: Thu, 12 Apr 2018 16:17:25 +0200 [thread overview]
Message-ID: <20180412141725.GN28963@lunn.ch> (raw)
In-Reply-To: <0bcc10cd-2a25-311f-d006-ddefe47567dc@raspberrypi.org>
On Thu, Apr 12, 2018 at 03:10:57PM +0100, Phil Elwell wrote:
> Hi Andrew,
>
> On 12/04/2018 15:04, Andrew Lunn wrote:
> > On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote:
> >> The Microchip LAN78XX family of devices are Ethernet controllers with
> >> a USB interface. Despite being discoverable devices it can be useful to
> >> be able to configure them from Device Tree, particularly in low-cost
> >> applications without an EEPROM or programmed OTP.
> >>
> >> Document the supported properties in a bindings file, adding it to
> >> MAINTAINERS at the same time.
> >
> > Hi Phil
> >
> > How you link an OF node to a USB device is not obvious. Could you
> > please include either a pointer to some binding documentation, or make
> > your example show it.
>
> Thanks for the feedback. Would you consider this (lifted from the Pi 3B+ Device Tree)
> a sufficient example?
Yes, this is good.
Thanks
Andrew
next prev parent reply other threads:[~2018-04-12 14:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 13:55 [PATCH 0/4] lan78xx: Read configuration from Device Tree Phil Elwell
2018-04-12 13:55 ` [PATCH 1/4] lan78xx: Read MAC address from DT if present Phil Elwell
2018-04-12 14:06 ` Andrew Lunn
2018-04-12 14:18 ` Phil Elwell
2018-04-12 13:55 ` [PATCH 2/4] lan78xx: Read initial EEE setting from Device Tree Phil Elwell
2018-04-12 14:16 ` Andrew Lunn
2018-04-12 15:17 ` Phil Elwell
2018-04-12 13:55 ` [PATCH 3/4] lan78xx: Read LED modes " Phil Elwell
2018-04-12 14:26 ` Andrew Lunn
2018-04-12 14:30 ` Phil Elwell
2018-04-12 14:36 ` Andrew Lunn
2018-04-12 15:21 ` Woojung.Huh
2018-04-12 13:55 ` [PATCH 4/4] dt-bindings: Document the DT bindings for lan78xx Phil Elwell
2018-04-12 14:04 ` Andrew Lunn
2018-04-12 14:10 ` Phil Elwell
2018-04-12 14:17 ` Andrew Lunn [this message]
2018-04-12 14:30 ` Andrew Lunn
2018-04-12 14:33 ` Phil Elwell
2018-04-16 19:22 ` Rob Herring
2018-04-17 11:35 ` Phil Elwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412141725.GN28963@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@raspberrypi$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox