From: "Michael S. Tsirkin" <mst@redhat•com>
To: Vladislav Yasevich <vyasevich@gmail•com>
Cc: netdev@vger•kernel.org, linux-sctp@vger•kernel.org,
virtualization@lists•linux-foundation.org, jasowang@redhat•com,
nhorman@tuxdriver•com, Vladislav Yasevich <vyasevic@redhat•com>
Subject: Re: [PATCH net-next 4/5] tun: Add support for SCTP checksum offload
Date: Mon, 16 Apr 2018 20:12:03 +0300 [thread overview]
Message-ID: <20180416201004-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180402134006.10111-5-vyasevic@redhat.com>
On Mon, Apr 02, 2018 at 09:40:05AM -0400, Vladislav Yasevich wrote:
> Adds a new tun offload flag to allow for SCTP checksum offload.
> The flag has to be set by the user and defaults to "no offload".
>
> Signed-off-by: Vladislav Yasevich <vyasevic@redhat•com>
When would user set this flag? Wouldn't that be when
userspace is ready to get SCTP packets without a checksum?
Seems to be this is an indication that when userspace
is qemu running a guest, said guest needs to communicate
the new ability to qemu.
> ---
> drivers/net/tun.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index a1ba262..263bcbe 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -2719,6 +2719,11 @@ static int set_offload(struct tun_struct *tun, unsigned long arg)
> arg &= ~TUN_F_UFO;
> }
>
> + if (arg & TUN_F_SCTP_CSUM) {
> + features |= NETIF_F_SCTP_CRC;
> + arg &= ~TUN_F_SCTP_CSUM;
> + }
> +
> /* This gives the user a way to test for new features in future by
> * trying to set them. */
> if (arg)
> --
> 2.9.5
next prev parent reply other threads:[~2018-04-16 17:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 13:40 [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support Vladislav Yasevich
2018-04-02 13:40 ` [PATCH net-next 1/5] virtio: Add support for SCTP checksum offloading Vladislav Yasevich
2018-04-10 3:17 ` Jason Wang
2018-04-11 22:39 ` Marcelo Ricardo Leitner
2018-04-11 22:49 ` Michael S. Tsirkin
2018-04-16 13:45 ` Vlad Yasevich
2018-04-16 15:52 ` Michael S. Tsirkin
2018-04-16 17:09 ` Michael S. Tsirkin
2018-04-17 19:06 ` Vlad Yasevich
2018-04-16 17:07 ` Michael S. Tsirkin
2018-04-02 13:40 ` [PATCH net-next 2/5] sctp: Handle sctp packets with CHECKSUM_PARTIAL Vladislav Yasevich
2018-04-02 13:40 ` [PATCH net-next 3/5] sctp: Build sctp offload support into the base kernel Vladislav Yasevich
2018-04-02 13:40 ` [PATCH net-next 4/5] tun: Add support for SCTP checksum offload Vladislav Yasevich
2018-04-03 0:49 ` kbuild test robot
2018-04-16 17:12 ` Michael S. Tsirkin [this message]
2018-04-02 13:40 ` [PATCH net-next 5/5] macvlan/macvtap: " Vladislav Yasevich
2018-04-04 15:31 ` Davide Caratti
2018-04-16 17:14 ` Michael S. Tsirkin
2018-04-02 14:16 ` [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support David Miller
2018-04-02 14:47 ` Marcelo Ricardo Leitner
2018-04-17 20:35 ` Vlad Yasevich
2018-04-18 1:33 ` Marcelo Ricardo Leitner
2018-04-18 6:57 ` Xin Long
2018-04-18 14:06 ` Michael S. Tsirkin
2018-04-20 17:22 ` Marcelo Ricardo Leitner
2018-04-20 18:32 ` Michael S. Tsirkin
2018-04-23 13:17 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416201004-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=vyasevic@redhat$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox