public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: daniel@iogearbox•net, alexei.starovoitov@gmail•com,
	netdev@vger•kernel.org, bjorn.topel@intel•com,
	magnus.karlsson@intel•com, eugenia@mellanox•com,
	jasowang@redhat•com, john.fastabend@gmail•com,
	eranbe@mellanox•com, saeedm@mellanox•com, galp@mellanox•com,
	borkmann@iogearbox•net, tariqt@mellanox•com, brouer@redhat•com
Subject: Re: [net-next V11 PATCH 00/17] XDP redirect memory return API
Date: Tue, 17 Apr 2018 18:27:03 +0200	[thread overview]
Message-ID: <20180417182703.62ab868f@redhat.com> (raw)
In-Reply-To: <20180417.113548.676760038759107548.davem@davemloft.net>

On Tue, 17 Apr 2018 11:35:48 -0400 (EDT)
David Miller <davem@davemloft•net> wrote:

> From: Daniel Borkmann <daniel@iogearbox•net>
> Date: Tue, 17 Apr 2018 17:24:03 +0200
> 
> > On 04/17/2018 05:18 PM, David Miller wrote:  
> >> From: Alexei Starovoitov <alexei.starovoitov@gmail•com>
> >> Date: Tue, 17 Apr 2018 07:48:42 -0700
> >>   
> >>> On Tue, Apr 17, 2018 at 04:45:16PM +0200, Jesper Dangaard Brouer wrote:  
> >>>> Submitted against net-next, as it contains NIC driver changes.
> >>>>
> >>>> This patchset works towards supporting different XDP RX-ring memory
> >>>> allocators.  As this will be needed by the AF_XDP zero-copy mode.  
> >>  ...  
> >>> The series look good to me now.
> >>> Acked-by: Alexei Starovoitov <ast@kernel•org>  
> >> 
> >> Pushed out to net-next, thanks everyone!  
> > 
> > See my comment on the last patch which is actually buggy. But given it's
> > pushed out already, then it needs to be fixed as follow-up..  
> 
> Yes it will need to be dealt with as a follow-up.

Okay, will deal with this as a followup.

That was actually why I submitted V10 without the last patch, as I
though that required separate upstream review, which turned out to be
true.  And I was planning to submit it after V10 was accepted. (I did
have the last patch in "offlist" review with Alexei and Daniel (but I
guess Daniel didn't had time to review it, I just falsely assumed he
had looked at it)).

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

      reply	other threads:[~2018-04-17 16:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 14:45 [net-next V11 PATCH 00/17] XDP redirect memory return API Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 01/17] mlx5: basic XDP_REDIRECT forward support Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 02/17] xdp: introduce xdp_return_frame API and use in cpumap Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 03/17] ixgbe: use xdp_return_frame API Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 04/17] xdp: move struct xdp_buff from filter.h to xdp.h Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 05/17] xdp: introduce a new xdp_frame type Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 06/17] tun: convert to use generic xdp_frame and xdp_return_frame API Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 07/17] virtio_net: " Jesper Dangaard Brouer
2018-04-17 14:45 ` [net-next V11 PATCH 08/17] bpf: cpumap convert to use generic xdp_frame Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 09/17] i40e: convert to use generic xdp_frame and xdp_return_frame API Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 10/17] mlx5: register a memory model when XDP is enabled Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 11/17] xdp: rhashtable with allocator ID to pointer mapping Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 12/17] page_pool: refurbish version of page_pool code Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 13/17] xdp: allow page_pool as an allocator type in xdp_return_frame Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 14/17] mlx5: use page_pool for xdp_return_frame call Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 15/17] xdp: transition into using xdp_frame for return API Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 16/17] xdp: transition into using xdp_frame for ndo_xdp_xmit Jesper Dangaard Brouer
2018-04-17 14:46 ` [net-next V11 PATCH 17/17] xdp: avoid leaking info stored in frame data on page reuse Jesper Dangaard Brouer
2018-04-17 15:04   ` Daniel Borkmann
2018-04-17 14:48 ` [net-next V11 PATCH 00/17] XDP redirect memory return API Alexei Starovoitov
2018-04-17 15:18   ` David Miller
2018-04-17 15:24     ` Daniel Borkmann
2018-04-17 15:35       ` David Miller
2018-04-17 16:27         ` Jesper Dangaard Brouer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417182703.62ab868f@redhat.com \
    --to=brouer@redhat$(echo .)com \
    --cc=alexei.starovoitov@gmail$(echo .)com \
    --cc=bjorn.topel@intel$(echo .)com \
    --cc=borkmann@iogearbox$(echo .)net \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=eranbe@mellanox$(echo .)com \
    --cc=eugenia@mellanox$(echo .)com \
    --cc=galp@mellanox$(echo .)com \
    --cc=jasowang@redhat$(echo .)com \
    --cc=john.fastabend@gmail$(echo .)com \
    --cc=magnus.karlsson@intel$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=saeedm@mellanox$(echo .)com \
    --cc=tariqt@mellanox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox