From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: vicentiu.galanopulo@nxp•com, robh@kernel•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
mark.rutland@arm•com, davem@davemloft•net, marcel@holtmann•org,
devicetree@vger•kernel.org, alexandru.marginean@nxp•com,
madalin.bucur@nxp•com
Subject: Re: [PATCH net-next 1/3] net: phy: Add binding for vendor specific C45 MDIO address space
Date: Tue, 17 Apr 2018 20:27:41 +0200 [thread overview]
Message-ID: <20180417182741.GC6688@lunn.ch> (raw)
In-Reply-To: <bc00cc86-2293-0fd2-4e98-c516f59f97ce@gmail.com>
On Tue, Apr 17, 2018 at 11:18:20AM -0700, Florian Fainelli wrote:
> On 04/17/2018 02:02 AM, Vicentiu Galanopulo wrote:
> > The extra property enables the discovery on the MDIO bus
> > of the PHYs which have a vendor specific address space
> > for accessing the C45 MDIO registers.
> >
> > Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@nxp•com>
> > ---
> > Documentation/devicetree/bindings/net/phy.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt
> > index d2169a5..82692e2 100644
> > --- a/Documentation/devicetree/bindings/net/phy.txt
> > +++ b/Documentation/devicetree/bindings/net/phy.txt
> > @@ -61,6 +61,11 @@ Optional Properties:
> > - reset-deassert-us: Delay after the reset was deasserted in microseconds.
> > If this property is missing the delay will be skipped.
> >
> > +- dev-addr: If set, it indicates the device address of the PHY to be used
> > + when accessing the C45 PHY registers over MDIO. It is used for vendor specific
> > + register space addresses that do no conform to standard address for the MDIO
> > + registers (e.g. MMD30)
>
> Rob made that comment earlier, and I have to ask again now, why don't we
> have the Clause 45 PHY binding be modified such that you have a reg
> property that has #address-size = 2? This should be entirely backwards
> compatible, but it would allow you to specify that device address in a
> more traditional way.
Hi Florian
I think we might get into trouble when we have both c22 and c45 on the
same bus. Two different reg formats. I would have to try it and see to
be sure.
Andrew
next prev parent reply other threads:[~2018-04-17 18:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 9:02 [PATCH net-next 0/3] net: phy: Enable C45 vendor specific MDIO register addr space Vicentiu Galanopulo
2018-04-17 9:02 ` [PATCH net-next 1/3] net: phy: Add binding for vendor specific C45 MDIO address space Vicentiu Galanopulo
2018-04-17 12:53 ` Andrew Lunn
2018-04-17 18:18 ` Florian Fainelli
2018-04-17 18:27 ` Andrew Lunn [this message]
2018-04-17 18:29 ` Florian Fainelli
2018-04-24 13:14 ` Rob Herring
2018-04-17 9:02 ` [PATCH net-next 2/3] net: phy: Change the array size to 32 for device_ids Vicentiu Galanopulo
2018-04-17 12:54 ` Andrew Lunn
2018-04-17 18:18 ` Florian Fainelli
2018-04-17 9:02 ` [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space Vicentiu Galanopulo
2018-04-17 12:56 ` Andrew Lunn
2018-04-17 18:27 ` Florian Fainelli
2018-04-18 9:38 ` Vicenţiu Galanopulo
2018-04-18 12:27 ` Andrew Lunn
2018-04-25 22:46 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417182741.GC6688@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandru.marginean@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=madalin.bucur@nxp$(echo .)com \
--cc=marcel@holtmann$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh@kernel$(echo .)org \
--cc=vicentiu.galanopulo@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox