public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Nikita V. Shirokov" <tehnerd@tehnerd•com>
To: Alexei Starovoitov <ast@kernel•org>,
	Daniel Borkmann <daniel@iogearbox•net>
Cc: netdev@vger•kernel.org, "Nikita V. Shirokov" <tehnerd@tehnerd•com>
Subject: [PATCH bpf-next v2 09/11] bpf: making bpf_prog_test run aware of possible data_end ptr change
Date: Tue, 17 Apr 2018 21:29:49 -0700	[thread overview]
Message-ID: <20180418042951.17183-10-tehnerd@tehnerd.com> (raw)
In-Reply-To: <20180418042951.17183-1-tehnerd@tehnerd.com>

after introduction of bpf_xdp_adjust_tail helper packet length
could be changed not only if xdp->data pointer has been changed
but xdp->data_end as well. making bpf_prog_test_run aware of this
possibility
---
 net/bpf/test_run.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
index 2ced48662c1f..68c3578343b4 100644
--- a/net/bpf/test_run.c
+++ b/net/bpf/test_run.c
@@ -170,7 +170,8 @@ int bpf_prog_test_run_xdp(struct bpf_prog *prog, const union bpf_attr *kattr,
 	xdp.rxq = &rxqueue->xdp_rxq;
 
 	retval = bpf_test_run(prog, &xdp, repeat, &duration);
-	if (xdp.data != data + XDP_PACKET_HEADROOM + NET_IP_ALIGN)
+	if (xdp.data != data + XDP_PACKET_HEADROOM + NET_IP_ALIGN ||
+	    xdp.data_end != xdp.data + size)
 		size = xdp.data_end - xdp.data;
 	ret = bpf_test_finish(kattr, uattr, xdp.data, size, retval, duration);
 	kfree(data);
-- 
2.15.1

  parent reply	other threads:[~2018-04-18  6:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  4:29 [PATCH bpf-next v2 00/11] introduction of bpf_xdp_adjust_tail Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 01/11] bpf: adding bpf_xdp_adjust_tail helper Nikita V. Shirokov
2018-04-18 16:56   ` Alexei Starovoitov
2018-04-18  4:29 ` [PATCH bpf-next v2 02/11] bpf: make generic xdp compatible w/ bpf_xdp_adjust_tail Nikita V. Shirokov
2018-04-18 12:48   ` Jesper Dangaard Brouer
2018-04-18  4:48     ` Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 03/11] bpf: make mlx4 " Nikita V. Shirokov
2018-04-18 10:53   ` Tariq Toukan
2018-04-18  4:29 ` [PATCH bpf-next v2 04/11] bpf: make bnxt " Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 05/11] bpf: make cavium thunder " Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 06/11] bpf: make netronome nfp " Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 07/11] bpf: make tun " Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 08/11] bpf: make virtio " Nikita V. Shirokov
2018-04-18  4:29 ` Nikita V. Shirokov [this message]
2018-04-18  4:29 ` [PATCH bpf-next v2 10/11] bpf: adding tests for bpf_xdp_adjust_tail Nikita V. Shirokov
2018-04-18  4:29 ` [PATCH bpf-next v2 11/11] bpf: add bpf_xdp_adjust_tail sample prog Nikita V. Shirokov
2018-04-18 12:37 ` [PATCH bpf-next v2 00/11] introduction of bpf_xdp_adjust_tail Daniel Borkmann
2018-04-18  4:44   ` Nikita V. Shirokov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418042951.17183-10-tehnerd@tehnerd.com \
    --to=tehnerd@tehnerd$(echo .)com \
    --cc=ast@kernel$(echo .)org \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox