From: Andrew Lunn <andrew@lunn•ch>
To: Chris Ruehl <chris.ruehl@gtsys•com.hk>
Cc: f.fainelli@gmail•com, netdev@vger•kernel.org
Subject: Re: [Regression] net/phy/micrel.c v4.9.94
Date: Wed, 18 Apr 2018 14:43:03 +0200 [thread overview]
Message-ID: <20180418124303.GD31643@lunn.ch> (raw)
In-Reply-To: <22ccc548-0000-1873-1ea0-1aad140d7131@gtsys.com.hk>
> If I look at the patch I think it should call kszphy_config_init() not _reset()
> in the resume function:
>
>
> @@ -715,8 +723,14 @@ static int kszphy_suspend(struct phy_device *phydev)
>
> static int kszphy_resume(struct phy_device *phydev)
> {
> + int ret;
> +
> genphy_resume(phydev);
>
> - ret = kszphy_config_reset(phydev);
> + ret = kszphy_config_init(phydev);
> + if (ret)
> + return ret;
> +
>
Hi Chris
I think there has been a patch for this posted. If i remember
correctly, the PHY you have does not call probe, hence phydev->priv is
a NULL pointer, so priv->rmii_ref_clk_sel does not work.
It would be good to find the patch and make sure it has been accepted,
and marked for stable.
Andrew
next prev parent reply other threads:[~2018-04-18 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 1:34 [Regression] net/phy/micrel.c v4.9.94 Chris Ruehl
2018-04-18 5:09 ` Chris Ruehl
2018-04-18 12:43 ` Andrew Lunn [this message]
2018-04-18 12:56 ` Andrew Lunn
2018-04-18 13:02 ` Andrew Lunn
2018-04-19 1:21 ` Chris Ruehl
2018-04-19 1:34 ` Chris Ruehl
2018-04-19 2:34 ` Chris Ruehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418124303.GD31643@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=chris.ruehl@gtsys$(echo .)com.hk \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox