From: Greg KH <gregkh@linuxfoundation•org>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio•com>
Cc: netdev@vger•kernel.org, kexec@lists•infradead.org,
linux-fsdevel@vger•kernel.org, linux-kernel@vger•kernel.org,
davem@davemloft•net, viro@zeniv•linux.org.uk,
ebiederm@xmission•com, stephen@networkplumber•org,
akpm@linux-foundation•org, torvalds@linux-foundation•org,
ganeshgr@chelsio•com, nirranjan@chelsio•com,
indranil@chelsio•com
Subject: Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel
Date: Thu, 19 Apr 2018 10:24:56 +0200 [thread overview]
Message-ID: <20180419082456.GA8617@kroah.com> (raw)
In-Reply-To: <e69b49f1406d2dcd9cd68e4300939e96cd745559.1523950324.git.rahul.lakkireddy@chelsio.com>
On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote:
> +config PROC_VMCORE_DEVICE_DUMP
> + bool "Device Hardware/Firmware Log Collection"
> + depends on PROC_VMCORE
> + default y
Only things that require the machine to keep working should be 'default
y', please remove this, it's an option.
> + help
> + Device drivers can collect the device specific snapshot of
> + their hardware or firmware before they are initialized in
> + crash recovery kernel. If you say Y here, the device dumps
> + will be added as ELF notes to /proc/vmcore
Which exact "device drivers" are you referring to here?
thanks,
greg k-h
next prev parent reply other threads:[~2018-04-19 8:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 7:44 [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel Rahul Lakkireddy
2018-04-17 7:44 ` [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel Rahul Lakkireddy
2018-04-19 8:24 ` Greg KH [this message]
2018-04-19 14:56 ` Rahul Lakkireddy
[not found] ` <cover.1523950321.git.rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2018-04-17 7:44 ` [PATCH net-next v4 2/3] vmcore: append device dumps to vmcore as elf notes Rahul Lakkireddy
2018-04-17 7:44 ` [PATCH net-next v4 3/3] cxgb4: collect hardware dump in second kernel Rahul Lakkireddy
2018-04-18 6:15 ` [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel Dave Young
[not found] ` <20180418061546.GA4551-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2018-04-18 12:31 ` Rahul Lakkireddy
2018-04-18 14:28 ` Eric W. Biederman
2018-04-18 15:07 ` Rahul Lakkireddy
2018-04-19 1:40 ` Dave Young
2018-04-19 14:27 ` Rahul Lakkireddy
2018-04-19 14:53 ` Eric W. Biederman
2018-04-20 13:06 ` Rahul Lakkireddy
2018-04-20 13:36 ` Eric W. Biederman
2018-04-20 14:51 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419082456.GA8617@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=indranil@chelsio$(echo .)com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nirranjan@chelsio$(echo .)com \
--cc=rahul.lakkireddy@chelsio$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox