From: "Michael S. Tsirkin" <mst@redhat•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: Jiri Pirko <jiri@resnulli•us>,
Sridhar Samudrala <sridhar.samudrala@intel•com>,
davem@davemloft•net, netdev@vger•kernel.org,
virtualization@lists•linux-foundation.org,
virtio-dev@lists•oasis-open.org, jesse.brandeburg@intel•com,
alexander.h.duyck@intel•com, kubakici@wp•pl, jasowang@redhat•com,
loseweigh@gmail•com
Subject: Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework
Date: Mon, 23 Apr 2018 20:56:09 +0300 [thread overview]
Message-ID: <20180423205019-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180423104440.2fe6cfd2@xeon-e3>
On Mon, Apr 23, 2018 at 10:44:40AM -0700, Stephen Hemminger wrote:
> On Mon, 23 Apr 2018 20:24:56 +0300
> "Michael S. Tsirkin" <mst@redhat•com> wrote:
>
> > On Mon, Apr 23, 2018 at 10:04:06AM -0700, Stephen Hemminger wrote:
> > > > >
> > > > >I will NAK patches to change to common code for netvsc especially the
> > > > >three device model. MS worked hard with distro vendors to support transparent
> > > > >mode, ans we really can't have a new model; or do backport.
> > > > >
> > > > >Plus, DPDK is now dependent on existing model.
> > > >
> > > > Sorry, but nobody here cares about dpdk or other similar oddities.
> > >
> > > The network device model is a userspace API, and DPDK is a userspace application.
> >
> > It is userspace but are you sure dpdk is actually poking at netdevs?
> > AFAIK it's normally banging device registers directly.
> >
> > > You can't go breaking userspace even if you don't like the application.
> >
> > Could you please explain how is the proposed patchset breaking
> > userspace? Ignoring DPDK for now, I don't think it changes the userspace
> > API at all.
> >
>
> The DPDK has a device driver vdev_netvsc which scans the Linux network devices
> to look for Linux netvsc device and the paired VF device and setup the
> DPDK environment. This setup creates a DPDK failsafe (bondingish) instance
> and sets up TAP support over the Linux netvsc device as well as the Mellanox
> VF device.
>
> So it depends on existing 2 device model. You can't go to a 3 device model
> or start hiding devices from userspace.
Okay so how does the existing patch break that? IIUC does not go to
a 3 device model since netvsc calls failover_register directly.
> Also, I am working on associating netvsc and VF device based on serial number
> rather than MAC address. The serial number is how Windows works now, and it makes
> sense for Linux and Windows to use the same mechanism if possible.
Maybe we should support same for virtio ...
Which serial do you mean? From vpd?
I guess you will want to keep supporting MAC for old hypervisors?
It all seems like a reasonable thing to support in the generic core.
--
MST
next prev parent reply other threads:[~2018-04-23 17:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 1:42 [PATCH net-next v7 0/4] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-04-20 1:42 ` [PATCH v7 net-next 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-04-20 1:42 ` [PATCH v7 net-next 2/4] net: Introduce generic failover module Sridhar Samudrala
2018-04-20 2:44 ` Michael S. Tsirkin
2018-04-20 15:21 ` Samudrala, Sridhar
2018-04-20 15:34 ` Michael S. Tsirkin
2018-04-20 15:56 ` [virtio-dev] " Alexander Duyck
2018-04-20 16:03 ` Michael S. Tsirkin
2018-04-20 3:34 ` Michael S. Tsirkin
2018-04-22 17:06 ` Michael S. Tsirkin
2018-04-23 17:21 ` Samudrala, Sridhar
2018-04-22 18:29 ` kbuild test robot
2018-04-20 1:42 ` [PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-04-20 2:46 ` Michael S. Tsirkin
2018-04-22 15:41 ` kbuild test robot
2018-04-22 15:41 ` kbuild test robot
2018-04-20 1:42 ` [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-04-20 15:28 ` Stephen Hemminger
2018-04-20 15:43 ` Michael S. Tsirkin
2018-04-20 15:47 ` David Miller
2018-04-20 15:46 ` David Miller
2018-04-20 15:46 ` Samudrala, Sridhar
2018-04-20 16:00 ` Jiri Pirko
2018-04-23 17:04 ` Stephen Hemminger
2018-04-23 17:24 ` Michael S. Tsirkin
2018-04-23 17:44 ` Stephen Hemminger
2018-04-23 17:56 ` Michael S. Tsirkin [this message]
2018-04-23 19:44 ` Siwei Liu
2018-04-23 20:06 ` Michael S. Tsirkin
2018-04-24 1:28 ` Stephen Hemminger
2018-04-25 21:38 ` Siwei Liu
2018-04-25 22:22 ` Michael S. Tsirkin
2018-04-25 22:57 ` Siwei Liu
2018-04-26 0:18 ` Stephen Hemminger
2018-04-26 2:43 ` Michael S. Tsirkin
2018-04-26 2:28 ` Michael S. Tsirkin
2018-04-26 22:14 ` Siwei Liu
2018-04-26 23:42 ` Michael S. Tsirkin
2018-04-28 0:43 ` Siwei Liu
2018-04-24 1:25 ` Stephen Hemminger
2018-04-24 1:42 ` Michael S. Tsirkin
2018-04-24 5:07 ` Stephen Hemminger
2018-04-23 17:25 ` Jiri Pirko
2018-04-22 15:41 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423205019-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jasowang@redhat$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kubakici@wp$(echo .)pl \
--cc=loseweigh@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=virtio-dev@lists$(echo .)oasis-open.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox