Subject: Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc

From: Stephen Hemminger <[email-masked]>
Date: Fri, 27 Apr 2018 09:17:02 -0700

On Fri, 27 Apr 2018 14:17:06 +0200
Toke Høiland-Jørgensen <[email-masked]> wrote:

> +		} else if (strcmp(*argv, "datacentre") == 0) {
> +			interval = 100;
> +			target   =   5;
> +		} else if (strcmp(*argv, "lan") == 0) {
> +			interval = 1000;
> +			target   =   50;
> +		} else if (strcmp(*argv, "metro") == 0) {
> +			interval = 10000;
> +			target   =   500;
> +		} else if (strcmp(*argv, "regional") == 0) {
> +			interval = 30000;
> +			target    = 1500;
> +		} else if (strcmp(*argv, "internet") == 0) {
> +			interval = 100000;
> +			target   =   5000;
> +		} else if (strcmp(*argv, "oceanic") == 0) {
> +			interval = 300000;
> +			target   =  15000;
> +		} else if (strcmp(*argv, "satellite") == 0) {
> +			interval = 1000000;
> +			target   =   50000;
> +		} else if (strcmp(*argv, "interplanetary") == 0) {
> +			interval = 1000000000;
> +			target   =   50000000;
> +

There enough tuning entries of this type, that it would be better
to make a table that can be expanded.

The code should also only allow one of these options. Use duparg()?