From: Stephen Hemminger <stephen@networkplumber•org>
To: Sridhar Samudrala <sridhar.samudrala@intel•com>
Cc: mst@redhat•com, davem@davemloft•net, netdev@vger•kernel.org,
virtualization@lists•linux-foundation.org,
virtio-dev@lists•oasis-open.org, jesse.brandeburg@intel•com,
alexander.h.duyck@intel•com, kubakici@wp•pl, jasowang@redhat•com,
loseweigh@gmail•com, jiri@resnulli•us, aaron.f.brown@intel•com
Subject: Re: [PATCH net-next v10 2/4] net: Introduce generic failover module
Date: Mon, 7 May 2018 16:46:32 -0700 [thread overview]
Message-ID: <20180507164632.4f6c2eef@xeon-e3> (raw)
In-Reply-To: <1525731046-10989-3-git-send-email-sridhar.samudrala@intel.com>
On Mon, 7 May 2018 15:10:44 -0700
Sridhar Samudrala <sridhar.samudrala@intel•com> wrote:
> This provides a generic interface for paravirtual drivers to listen
> for netdev register/unregister/link change events from pci ethernet
> devices with the same MAC and takeover their datapath. The notifier and
> event handling code is based on the existing netvsc implementation.
>
> It exposes 2 sets of interfaces to the paravirtual drivers.
> 1. For paravirtual drivers like virtio_net that use 3 netdev model, the
> the failover module provides interfaces to create/destroy additional
> master netdev and all the slave events are managed internally.
> net_failover_create()
> net_failover_destroy()
> A failover netdev is created that acts a master device and controls 2
> slave devices. The original virtio_net netdev is registered as 'standby'
> netdev and a passthru/vf device with the same MAC gets registered as
> 'primary' netdev. Both 'standby' and 'failover' netdevs are associated
> with the same 'pci' device. The user accesses the network interface via
> 'failover' netdev. The 'failover' netdev chooses 'primary' netdev as
> default for transmits when it is available with link up and running.
> 2. For existing netvsc driver that uses 2 netdev model, no master netdev
> is created. The paravirtual driver registers each instance of netvsc
> as a 'failover' netdev along with a set of ops to manage the slave
> events. There is no 'standby' netdev in this model. A passthru/vf device
> with the same MAC gets registered as 'primary' netdev.
> net_failover_register()
> net_failover_unregister()
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel•com>
You are conflating the net_failover device (3 device model) with
the generic network failover infrastructure into one file. There should be two
seperate files net/core/failover.c and drivers/net/failover.c which splits
the work into two parts (and acts a check for the api).
next prev parent reply other threads:[~2018-05-07 23:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 22:10 [PATCH net-next v10 0/4] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-05-07 22:10 ` [PATCH net-next v10 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-05-07 22:10 ` [PATCH net-next v10 2/4] net: Introduce generic failover module Sridhar Samudrala
2018-05-07 22:39 ` Randy Dunlap
2018-05-11 15:43 ` Samudrala, Sridhar
2018-05-11 18:09 ` Michael S. Tsirkin
2018-05-07 23:46 ` Stephen Hemminger [this message]
2018-05-11 15:40 ` Samudrala, Sridhar
2018-05-07 23:53 ` Stephen Hemminger
2018-05-08 0:24 ` Samudrala, Sridhar
2018-05-11 17:15 ` Michael S. Tsirkin
2018-05-07 23:59 ` Stephen Hemminger
2018-05-08 0:11 ` Samudrala, Sridhar
2018-05-08 9:02 ` kbuild test robot
2018-05-07 22:10 ` [PATCH net-next v10 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-05-07 22:10 ` [PATCH net-next v10 4/4] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507164632.4f6c2eef@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=aaron.f.brown@intel$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jasowang@redhat$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kubakici@wp$(echo .)pl \
--cc=loseweigh@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=virtio-dev@lists$(echo .)oasis-open.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox