From: Mauro Carvalho Chehab <mchehab+samsung@kernel•org>
To: "Luis R. Rodriguez" <mcgrof@kernel•org>
Cc: gregkh@linuxfoundation•org, akpm@linux-foundation•org,
keescook@chromium•org, josh@joshtriplett•org, maco@android•com,
andy.gross@linaro•org, david.brown@linaro•org,
bjorn.andersson@linaro•org, teg@jklm•no, wagi@monom•org,
hdegoede@redhat•com, andresx7@gmail•com,
zohar@linux•vnet.ibm.com, kubakici@wp•pl, shuah@kernel•org,
mfuzzey@parkeon•com, dhowells@redhat•com, pali.rohar@gmail•com,
tiwai@suse•de, kvalo@codeaurora•org,
arend.vanspriel@broadcom•com, zajec5@gmail•com, nbroeking@me•com,
markivx@codeaurora•org, broonie@kernel•org,
dmitry.torokhov@gmail•com, dwmw2@infradead•org,
torvalds@linux-foundation•org, Abhay_Salunke@dell•com,
jewalt@lgsinnovations•com, oneukum@suse•com,
cantabile.desu@gmail•com, ast@fb•com, hare@suse•com,
jejb@linux•vnet.ibm.com, martin.petersen@oracle•com, khc
Subject: Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module
Date: Wed, 9 May 2018 10:21:08 -0300 [thread overview]
Message-ID: <20180509102108.7049f7a9@vento.lan> (raw)
In-Reply-To: <20180508181247.19431-14-mcgrof@kernel.org>
Em Tue, 8 May 2018 11:12:47 -0700
"Luis R. Rodriguez" <mcgrof@kernel•org> escreveu:
> Clarify the provenance of the firmware loader firmware_class module name
> and why we cannot rename the module in the future.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel•org>
> ---
> .../driver-api/firmware/fallback-mechanisms.rst | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/driver-api/firmware/fallback-mechanisms.rst b/Documentation/driver-api/firmware/fallback-mechanisms.rst
> index a39323ef7d29..a8047be4a96e 100644
> --- a/Documentation/driver-api/firmware/fallback-mechanisms.rst
> +++ b/Documentation/driver-api/firmware/fallback-mechanisms.rst
> @@ -72,9 +72,12 @@ the firmware requested, and establishes it in the device hierarchy by
> associating the device used to make the request as the device's parent.
> The sysfs directory's file attributes are defined and controlled through
> the new device's class (firmware_class) and group (fw_dev_attr_groups).
> -This is actually where the original firmware_class.c file name comes from,
> -as originally the only firmware loading mechanism available was the
> -mechanism we now use as a fallback mechanism.
> +This is actually where the original firmware_class module name came from,
> +given that originally the only firmware loading mechanism available was the
> +mechanism we now use as a fallback mechanism, which which registers a
> +struct class firmware_class. Because the attributes exposed are part of the
> +module name, the module name firmware_class cannot be renamed in the future, to
> +ensure backward compatibilty with old userspace.
Ah, now the explanation makes a lot more sense to me :-)
Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel•org>
>
> To load firmware using the sysfs interface we expose a loading indicator,
> and a file upload firmware into:
Thanks,
Mauro
next prev parent reply other threads:[~2018-05-09 13:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 18:12 [PATCH v6 00/13] firmware_loader changes for v4.18 Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 02/13] firmware: use () to terminate kernel-doc function names Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs() Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback() Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER Luis R. Rodriguez
2018-05-08 22:42 ` Kees Cook
2018-05-09 20:55 ` Luis R. Rodriguez
2018-05-09 23:01 ` Kees Cook
2018-05-08 18:12 ` [PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 12/13] Documentation: remove stale firmware API reference Luis R. Rodriguez
2018-05-09 15:12 ` Mauro Carvalho Chehab
2018-05-09 19:43 ` Luis R. Rodriguez
2018-05-08 18:12 ` [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module Luis R. Rodriguez
2018-05-08 18:53 ` Andres Rodriguez
2018-05-09 13:21 ` Mauro Carvalho Chehab [this message]
2018-05-08 22:45 ` [PATCH v6 00/13] firmware_loader changes for v4.18 Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509102108.7049f7a9@vento.lan \
--to=mchehab+samsung@kernel$(echo .)org \
--cc=Abhay_Salunke@dell$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andresx7@gmail$(echo .)com \
--cc=andy.gross@linaro$(echo .)org \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=ast@fb$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=cantabile.desu@gmail$(echo .)com \
--cc=david.brown@linaro$(echo .)org \
--cc=dhowells@redhat$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hare@suse$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=jejb@linux$(echo .)vnet.ibm.com \
--cc=jewalt@lgsinnovations$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kubakici@wp$(echo .)pl \
--cc=kvalo@codeaurora$(echo .)org \
--cc=maco@android$(echo .)com \
--cc=markivx@codeaurora$(echo .)org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=mfuzzey@parkeon$(echo .)com \
--cc=nbroeking@me$(echo .)com \
--cc=oneukum@suse$(echo .)com \
--cc=pali.rohar@gmail$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=teg@jklm$(echo .)no \
--cc=tiwai@suse$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=wagi@monom$(echo .)org \
--cc=zajec5@gmail$(echo .)com \
--cc=zohar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox