Subject: Re: [PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf

From: Jesper Dangaard Brouer <[email-masked]>
Date: Sat, 12 May 2018 10:39:06 +0200

On Fri, 11 May 2018 17:17:25 -0700
Jakub Kicinski <[email-masked]> wrote:

> Following patches address build issues after recent move to libbpf.
> For out-of-tree builds we would see the following error:
> 
> gcc: error: samples/bpf/../../tools/lib/bpf/libbpf.a: No such file or directory
> 
> Mini-library called libbpf.h in samples is renamed to bpf_insn.h,
> using linux/filter.h seems not completely trivial since some samples
> get upset when order on include search path in changed.  We do have
> to rename libbpf.h, however, because otherwise it's hard to reliably
> get to libbpf's header in out-of-tree builds.

Acked-by: Jesper Dangaard Brouer <[email-masked]>

Thank you for doing this... this mini-library also called libbpf.h have
confused me before, and I bet it will/would confuse others as well.
Glad to see it being renamed :-)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer