From: Greg KH <gregkh@linuxfoundation•org>
To: Stefan Schmidt <stefan@datenfreihafen•org>
Cc: Stefan Schmidt <stefan@osg•samsung.com>,
stable@vger•kernel.org, Alexander Aring <aring@mojatatu•com>,
"David S. Miller" <davem@davemloft•net>,
"linux-wpan@vger•kernel.org" <linux-wpan@vger•kernel.org>,
Network Development <netdev@vger•kernel.org>
Subject: Re: net: ieee802154: 6lowpan: fix frag reassembly
Date: Thu, 17 May 2018 17:59:08 +0200 [thread overview]
Message-ID: <20180517155908.GA4831@kroah.com> (raw)
In-Reply-To: <d70c35cd-2795-70f1-a7fc-2785c7938fac@datenfreihafen.org>
On Thu, May 17, 2018 at 04:16:20PM +0200, Stefan Schmidt wrote:
> Hello Greg.
>
> On 17.05.2018 10:59, Greg KH wrote:
> > On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote:
> >> Hello.
> >>
> >>
> >> Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948
> >>
> >> (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree.
> >>
> >>
> >> Earlier trees are not needed as the problem was introduced in 4.16.
> >
> > Really? Commit f18fa5de5ba7 ("net: ieee802154: 6lowpan: fix frag
> > reassembly") says it fixes commit 648700f76b03 ("inet: frags: use
> > rhashtables for reassembly units") which did not show up until 4.17-rc1:
> > $ git describe --contains 648700f76b03
> > v4.17-rc1~148^2~20^2~11
> >
> > Also, it did not get backported to 4.16.y, so I don't see how it is
> > needed in 4.16-stable.
>
> I guess its time to blush on my side. During the bisection for the
> commit that introduced the problem I came to the point where it was
> clear to me that it was already in 4.16. This was a while back I have
> have honestly no idea how I did this mistake.
>
> I tested again now with plain 4.16 and it works fine.
> The fix is also in 4.17-rcX where it actually is needed. In the end I am
> glad that it was not introduced and slipped me in an earlier release.
>
> > To verify this, I tried applying the patch, and it totally fails to
> > apply to the 4.16.y tree.
> >
> > So are you _sure_ you want/need this in 4.16? If so, can you provide a
> > working backport that you have verified works?
>
> No backport needed. I simply screwed up when verifying this for 4.16.
> I put on the hat of shame for today and will try harder the next time.
Hey, not a problem, thanks for verifying, 'git describe --contains' is
your friend :)
thanks,
greg k-h
prev parent reply other threads:[~2018-05-17 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 15:22 net: ieee802154: 6lowpan: fix frag reassembly Stefan Schmidt
2018-05-14 15:31 ` Greg KH
2018-05-14 16:13 ` David Miller
2018-05-17 8:59 ` Greg KH
2018-05-17 14:16 ` Stefan Schmidt
2018-05-17 15:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517155908.GA4831@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=aring@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=stefan@datenfreihafen$(echo .)org \
--cc=stefan@osg$(echo .)samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox